Hi,

ok I see - so it was done on purpose do be able to decide when to claim any 
land around the colony.

An "unclaim land" action is not necessary, I agree.

For the "lost" lumber when clearing the forrest:
Wouldn't it then be the solution to claim the land as soon as the pioneer 
clears the forrest?
So, claim the land for the colony, of course (setting the owningSettlement 
property).
I would do this for all improvement actions which are in colony radius. 
(I think improvements cause claiming the tile anyway, but not for any colony in 
range).

I added a patch for this (only):
This patch should then claim any tile for a surrounding settlement of the 
claiming player which is in the tile's settlement range (added constant for 
that in SettlementType - this maybe intended to be a modifyable property in the 
future?).

So if you clear then a forrest (or any other claimland action with a unit), the 
tile would also be added to the player's next settlement. This fixes also the 
"lost-lumber" I described.

If you see other side-effects of this, tell me!

BR,
Stefan!

-- 
 Sent with Tutanota, the secure & ad-free mailbox. 



Dec 13, 2021, 23:09 by mp...@computer.org:

> On Mon, 13 Dec 2021 13:11:46 +0100 (CET)
> Stefan Fellner via Freecol-developers
> <freecol-developers@lists.sourceforge.net> wrote:
>
>> just a question as I noticed this during playing:
>> Is this on purpose that when building a colony that the surrounding tiles 
>> are not claimed automatically?
>>
>
> Yes.  Some players complained that they did not want to claim certain
> tiles for various reasons (most commonly, to avoid annoying nearby
> natives).  As there is no mechanism for un-claiming a tile, we made
> claiming not happen by default.  AFAICT most players usually just claim all
> the free land around a colony shortly after founding it so as to avoid
> aggressive other Europeans or wandering natives claiming the land, as they
> sometimes do.
>
>> At least the one's which are not owned by another party (indians for the 
>> most);
>> It occurred to me when clearing a forrest with a pioneer on a then 
>> "unclaimed" colony tile would usually add lumber to the colony's stock, 
>> which when it is not "claimed" for the settlement does not work (get's lost).
>>
>
> Correct, the lumber would be lost.  I think this is a rare case and easily
> avoided.  The alternative would be to add an un-claim land action, which
> probably needs a new command and client-server message.  When this was
> last discussed we decided not to further clutter the command list with
> another very specialized command.
>
> Cheers,
> Mike Pope
>

Attachment: claim-land-unit-improvement.patch
Description: Binary data

_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to