Hi, On Mon, Aug 27, 2012 at 1:31 PM, Bitácora de Javier Gutiérrez Chamorro (Guti) <guti.bitacoras....@gmail.com> wrote: > > Glad you found it useful! > If in the meantime you have any comment or suggestion, do not > hesitate posting.
I've thought about writing such a util myself. It's indeed useful, thanks. Comments are fairly useless, but if you insist .... ;-) 1). build.bat -- You use a lot of cmdline options! Perhaps overkill, esp. the needless extra %INCLUDE% and %PATH% for other OS (OpenWatcom) binaries. Actually, I just recently fiddled a bit with OW's WMAKE for the first time, it's quite nice. Could simplify your efforts, though I normally eschew (sp?) complicated makefiles. I don't know if cmdline options override %WCL%, but I assume so. I'm also not so sure "OP ELIMINATE" works here, or at least not the way you think it does or should. (Putting code in .OBJ in separate segments for linker to strip?) At least, in my limited experience, it didn't. 2). The text file (zerofill.txt) has very long lines, apparently max is 265! I know most of us know how to (semi-)automatically wrap them, just saying ... kinda silly! :-P 3). You didn't UPX it. "--ultra-brute --8086" won't shave much, but it does make it from 9448 to 7308. Hardly worth mentioning, but anyways .... 4). zerofill.c -- BUFSIZE? At least you didn't clash with stdio's BUFSIZ. Perhaps stdint.h's SIZE_MAX (e.g. SIZE_MAX/2) would be more useful here? So you don't (yet) use 0x7303 (FAT32)? BTW, WinXP doesn't support that, but FreeDOS does. I'm not exactly sure what XP does, it seems to report kilobytes free via 36h (due to small reg size), but don't quote me on that. I think DJGPP 2.04 /beta/ "df" and "du" (FIL41B.ZIP, aka FileUtils) are more accurate on 2+ GB than previously due to similar reasoning. Oops, you use "1048575" without any suffix. Doesn't it need "L" here? Similarly "return(0);" should be "return EXIT_SUCCESS;" Otherwise, I guess? it's fine, as long as it works as intended! ;-) ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freedos-devel mailing list Freedos-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-devel
