Thank you very much Rugxulo for your suggestions. I have released ZEROFILL 1.02, available at http://nikkhokkho.sourceforge.net/static.php?page=ZEROFILL with some of your suggestions added: 3) ZEROFILL.COM is now 7277 bytes. 4) I am using INT_MAX + 1 as equivalent limit to 32676U. 6) You are right, 1048575 should be 1048575L. 7) Right, it is better to return EXIT_SUCCESS.
Nevertheless I have not implemented: 1) I do not think a MAKEFILE project for such a simple single one project makes sense, sorry. As for OPTION ELIMINATE, it is correct, it has no impact on this, since it is only one object file... I inherited it form other BUILD.BAT files I own. Since it does not hurt, and you never know if ZEROFILL will grow, I will keep it. 2) Most text editors support word wrapping, and not all users are using 80 columns width display, so I prefer it as a better option, and let your text editor/viewer do the job. Again, thank you very much for your very interesting thoughts. Regards. 2012/8/28 Rugxulo <rugx...@gmail.com>: > Hi, > > On Mon, Aug 27, 2012 at 1:31 PM, Bitácora de Javier Gutiérrez Chamorro > (Guti) <guti.bitacoras....@gmail.com> wrote: >> >> Glad you found it useful! >> If in the meantime you have any comment or suggestion, do not >> hesitate posting. > > I've thought about writing such a util myself. It's indeed useful, thanks. > > Comments are fairly useless, but if you insist .... ;-) > > 1). build.bat -- You use a lot of cmdline options! Perhaps overkill, > esp. the needless extra %INCLUDE% and %PATH% for other OS (OpenWatcom) > binaries. Actually, I just recently fiddled a bit with OW's WMAKE for > the first time, it's quite nice. Could simplify your efforts, though I > normally eschew (sp?) complicated makefiles. I don't know if cmdline > options override %WCL%, but I assume so. I'm also not so sure "OP > ELIMINATE" works here, or at least not the way you think it does or > should. (Putting code in .OBJ in separate segments for linker to > strip?) At least, in my limited experience, it didn't. > > 2). The text file (zerofill.txt) has very long lines, apparently max > is 265! I know most of us know how to (semi-)automatically wrap them, > just saying ... kinda silly! :-P > > 3). You didn't UPX it. "--ultra-brute --8086" won't shave much, but it > does make it from 9448 to 7308. Hardly worth mentioning, but anyways > .... > > 4). zerofill.c -- BUFSIZE? At least you didn't clash with stdio's > BUFSIZ. Perhaps stdint.h's SIZE_MAX (e.g. SIZE_MAX/2) would be more > useful here? > > So you don't (yet) use 0x7303 (FAT32)? BTW, WinXP doesn't support > that, but FreeDOS does. I'm not exactly sure what XP does, it seems to > report kilobytes free via 36h (due to small reg size), but don't quote > me on that. I think DJGPP 2.04 /beta/ "df" and "du" (FIL41B.ZIP, aka > FileUtils) are more accurate on 2+ GB than previously due to similar > reasoning. > > Oops, you use "1048575" without any suffix. Doesn't it need "L" here? > Similarly "return(0);" should be "return EXIT_SUCCESS;" > > Otherwise, I guess? it's fine, as long as it works as intended! ;-) ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freedos-devel mailing list Freedos-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-devel
