2009/5/21 Eric Auer <e.a...@jpberlin.de>: > That is the point... > > svn diff -r1386:1388 > > gives a diff of 14 kilobytes, 12 files modified, > 46 lines changed, 170 lines added. Quite a lot.
> Okay okay I can analyze the patch myself... :-( Some explanations > from the author would have saved some time here, of course ;-). That makes it easier to answer, although you could have researched many of your question marks yourself too... Do you think the change is too big? Should it have been cut into more smaller changes than two? Or do you require a GNU style changelog like this? http://gcc.gnu.org/viewcvs/trunk/gcc/ChangeLog?revision=147771&view=markup > k. makefile: various target names: use slashes instead of backslash? Yes: / in targets works in DOS too. > - build.txt: add section about Linux (config.mak is Linux config bat?) Yes. Is that not clear enough? Do you have suggestions to improve the documentation? >- generic.mak: use slashes instead of backslash for includes? yes, because generic.mak needs to work on both DOS and Linux. >- generic.mak: if CLDEF not 0 then do something with CLT CLC? CLT/CLC are used for build utilities, using tiny and compact memory model. On Linux they are set to use plain gcc, but on DOS special settings are needed. > - owlinux.mak: defines ECHOTO as echo>> which looks odd... The reason for the existence of ECHOTO is (as briefly stated in kernel/makefile) that Turbo C 2.01 make cannot handle redirections. So I wrote a batch file that appends: ..\utils\echoto.bat file file1.obj file2.obj instead of writing echo file1.obj file2.obj >> file in the makefile. The batch file does not work in Linux obviously but wmake is smart enough to handle echo >>. > - utils makefile: use DIRSEP, drop use of INCLUDEPATH? > - utils makefile: use CLT CLC instead of CL > - utils makefile: drop TINY, CFLAGSC,CFLAGST? they're not dropped, but moved to generic.mak. > - config.m: is preconfigured for 8086 FAT16, interestingly It's not strange: I just copied the default from config.b. > - makefile: change all target into build target which does build? yes > - makefile: add some Linux section and some defaults (and DOS?) Nothing changed for DOS, except that "make" will give you a message. > - makefile: rewrite all/clean/clobber targets, big changes? just additions: this is like build/clobber/clean.bat for Linux, for DOS this is not used. > Are you sure this still works on DOS, even with Turbo C etc? :-) Of course, I tested what I could. Bart ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Freedos-kernel mailing list Freedos-kernel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-kernel
