Hi Bart, >> svn diff -r1386:1388 >> gives a diff of 14 kilobytes, 12 files modified, >> 46 lines changed, 170 lines added. Quite a lot.
> Do you think the change is too big? Too big to say "read the diff" instead of explaining what and how you changed, but not too big as patch :-) Many of your changes are nicely encapsulated into Linux specific sections and even separate files :-). > Should it have been cut into more > smaller changes than two? No, thanks :-) > Or do you require a GNU style changelog like this? > http://gcc.gnu.org/viewcvs/trunk/gcc/ChangeLog?revision=147771&view=markup No... I would not suggest more than 5-20 lines for the SVN commit log text for your patch, but would have been happy about more details than what is in the current commit log text ;-). > Yes: / in targets works in DOS too. With Turbo C as well, I assume :-) >> - build.txt: add section about Linux (config.mak is Linux config bat?) > Yes. Is that not clear enough? Do you have suggestions to > improve the documentation? Not really - I think it would be tricky to put the config variables in something that all used MAKE versions can deal with directly, as opposed to having both a BAT and a MAK? >> - generic.mak: use slashes instead of backslash for includes? > yes, because generic.mak needs to work on both DOS and Linux. As said, I was not aware that forward slashes work in both :-) > CLT/CLC are used for build utilities, using tiny and compact memory > model. On Linux they are set to use plain gcc, but on DOS special > settings are needed. Okay! >> - owlinux.mak: defines ECHOTO as echo>> which looks odd... ... > ..\utils\echoto.bat file file1.obj file2.obj > instead of writing > echo file1.obj file2.obj >> file Okay but "echo>> file file1.obj file2.obj" here? >> - utils makefile: drop TINY, CFLAGSC,CFLAGST? > they're not dropped, but moved to generic.mak. Oh :-) >> - config.m: is preconfigured for 8086 FAT16, interestingly > It's not strange: I just copied the default from config.b. Interesting. I often used the 386 FAT32 kernel as the kernel sys file when I made zips with all the K{TC,WC}{86,386}{16,32} SYS plus KERNEL SYS files. >> - makefile: change all target into build target which does build? > yes If a cronjob runs "make" it will only show messages from now on until somebody changes the cronjob, but of course this risk is purely hypothetical... :-). >> - makefile: rewrite all/clean/clobber targets, big changes? > just additions: this is like build/clobber/clean.bat for Linux, > for DOS this is not used. I was assuming they were for both, as they are just called "all" and not "alllinux" :-). >> Are you sure this still works on DOS, even with Turbo C etc? :-) > Of course, I tested what I could. Great, thanks :-) Eric ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Freedos-kernel mailing list Freedos-kernel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-kernel
