On 11/04/2011 06:22 PM, Endi Sukma Dewata wrote:
Rebased, ACK, and pushed to master. Some comments below.
On 11/4/2011 7:21 AM, Petr Vobornik wrote:
Perhaps the save_as_update_info() later can be merged with
get_update_info() too because both are essentially generating
update_info for dirty fields.
Yes, If we ensure that appropriate get_update_info() method will be in
each custom widget/section, which isn't now.
Attached preview patch for #1515. Also attaching diff patch of reviewed
patch.
OK, I see how the enable widget creates the update info. How would you
handle the removal of users in HBAC rule when the usercategory is
changed to ALL?
This logic is part of rule_association_table_widget:rule.js:142. The
radio buttons are triggering an event which disables/enables the asso.
table. During get_update_info if the asso. table is disabled and it has
entries in it, it creates a command which deletes the entries.
--
Petr Vobornik
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
