On 1/17/2012 9:36 AM, Endi Sukma Dewata wrote:
On 1/16/2012 8:02 AM, Petr Vobornik wrote:
1) Button position:
I added the button into facet header next to 'add', 'delete', 'reset',
'update' buttons as shown on the picture (
http://pvoborni.fedorapeople.org/images/2051-refresh-button.png ). I'm
not sure if it's the right position. I can also imagine it somewhere in
the page header - in the green area on the right on the top main menu
(Identity, Policy...) level.
I think it's the right place, but UXD might have some idea about the
button order.
2) Button icon:
I used reset button icon. This is not good because in details facet
reset and refresh button have the same icon.
I think this icon is more suitable for refresh button and reset button
should get new icon (maybe with reverse direction of the arrow).
Probably we should ask UXD for opinion and icon.
Yeah, maybe the Reset button probably should look like an Undo button:
http://www.iconarchive.com/show/must-have-icons-by-visualpharm/Undo-icon.html
The code is ACKed, feel free to push after feedback from UXD.
OK'd by Kyle in ticket #2051. Pushed to master and ipa-2-2.
One more issue, in the details page the Refresh and Reset buttons are
actually doing a similar thing. They both cancel unsaved changes in the
page, but the difference is the Reset button will show the values
originally loaded when you open the page (which might be stale) whereas
the Refresh button will reload the latest values from the server. So I
think we can remove the Refresh button from the details page and modify
the Reset button to do a refresh. We can leave the Undo buttons as is.
This way we don't need a new icon for Refresh. What do you think?
--
Endi S. Dewata
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
