Hardcoding the in-tree location for ipa-getkeytab makes testing outside
the source tree impossible. This patch makes the tests use the installed
location.
In other places the test suite assumes IPA is installed system-wide,
even if running from the source tree.
I know I frequently forget to run `make` before testing, which makes the
ipa-getkeytab tests fail. So this patch would work well for me (and
probably other Python devs), but I guess others might be used to `make
test` checking what `make` built.
C developers, are you OK with e.g. adding `cp ipa-client/ipa-getkeytab
/usr/sbin/ipa-getkeytab` to your testing workflow? Or should this be
made configurable (or auto-detected)?
--
Petr³
From 7464e7a18e344e45f1cd115aa41dc3c4ac460b2e Mon Sep 17 00:00:00 2001
From: Petr Viktorin <pvikt...@redhat.com>
Date: Mon, 3 Jun 2013 15:04:58 +0200
Subject: [PATCH] tests: Use ipa-getkeytab from /usr/sbin instead of the
in-tree one
Using the in-tree binary makes testing outside the source tree
impossible. Switch to the installed location.
Part of the work for https://fedorahosted.org/freeipa/ticket/3654
---
tests/test_cmdline/test_ipagetkeytab.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test_cmdline/test_ipagetkeytab.py b/tests/test_cmdline/test_ipagetkeytab.py
index cb46fd23bf320f59c30e53ceaa85d09aa7a3e2b4..f61b065c23a2aa9e9be3437d3013ea7556787d52 100644
--- a/tests/test_cmdline/test_ipagetkeytab.py
+++ b/tests/test_cmdline/test_ipagetkeytab.py
@@ -59,7 +59,7 @@ class test_ipagetkeytab(cmdline_test):
"""
Test `ipa-getkeytab`.
"""
- command = "ipa-client/ipa-getkeytab"
+ command = "/usr/sbin/ipa-getkeytab"
host_fqdn = u'ipatest.%s' % api.env.domain
service_princ = u'test/%s@%s' % (host_fqdn, api.env.realm)
[keytabfd, keytabname] = tempfile.mkstemp()
--
1.8.1.4
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
