On Fri, 07 Jun 2013, Tomas Babej wrote:
On 06/07/2013 03:41 PM, Alexander Bokovoy wrote:
Hi,
in patch 0061:
On Fri, 07 Jun 2013, Tomas Babej wrote:
+ range_types = {
+ u'ipa-local': unicode(_(u'local domain range')),
+ u'ipa-ad-winsync': unicode(_('Active Directory winsync
range')),
+ u'ipa-ad-trust': unicode(_('Active Directory domain range')),
+ u'ipa-ad-trust-posix': unicode(_('Active Directory
trust range with '
+ 'POSIX attributes')),
+ u'ipa-ipa-trust': unicode(_('IPA trust range')),
+ }
Why there is _(u'local domain range') and then others without Unicode
strings? Either way is fine but there should be consistency.
Sure, fixed.
The rest of this patch would be much shorter if there wouldn't
additional whitespace. Could you please git rid of that?
Whitespaces are intentional, these are fixes for PEP8 E302 errors.
If they are intentional, please send them as separate patch.
Sending the whole patchset updated.
Please split the whitespace fixes from the functional ones.
--
/ Alexander Bokovoy
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
