On 06/10/2013 10:52 AM, Tomas Babej wrote:
On 06/07/2013 05:44 PM, Alexander Bokovoy wrote:
On Fri, 07 Jun 2013, Tomas Babej wrote:
On 06/07/2013 03:41 PM, Alexander Bokovoy wrote:
Hi,
in patch 0061:
On Fri, 07 Jun 2013, Tomas Babej wrote:
+ range_types = {
+ u'ipa-local': unicode(_(u'local domain range')),
+ u'ipa-ad-winsync': unicode(_('Active Directory winsync
range')),
+ u'ipa-ad-trust': unicode(_('Active Directory domain range')),
+ u'ipa-ad-trust-posix': unicode(_('Active Directory trust
range with '
+ 'POSIX attributes')),
+ u'ipa-ipa-trust': unicode(_('IPA trust range')),
+ }
Why there is _(u'local domain range') and then others without Unicode
strings? Either way is fine but there should be consistency.
Sure, fixed.
The rest of this patch would be much shorter if there wouldn't
additional whitespace. Could you please git rid of that?
Whitespaces are intentional, these are fixes for PEP8 E302 errors.
If they are intentional, please send them as separate patch.
Sending the whole patchset updated.
Please split the whitespace fixes from the functional ones.
No problem, patches split.
Tomas
Hello,
I got a test failure, most likely caused by this patch. In
test_range_plugin.py, there are some manually added ranges without the
new required attribute.
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose/suite.py", line 208, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose/suite.py", line 291, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose/suite.py", line 314, in
setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose/util.py", line 469, in
try_run
return func()
File
"/var/lib/jenkins/workspace/install-and-make-test/tests/test_xmlrpc/test_range_plugin.py",
line 159, in setUpClass
self.add_entry(testrange9_dn, testrange9_add)
File
"/var/lib/jenkins/workspace/install-and-make-test/tests/test_xmlrpc/test_range_plugin.py",
line 148, in add_entry
self.connection.add_s(dn, ldif)
File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line
195, in add_s
return self.result(msgid,all=1,timeout=self.timeout)
File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line
458, in result
resp_type, resp_data, resp_msgid = self.result2(msgid,all,timeout)
File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line
462, in result2
resp_type, resp_data, resp_msgid, resp_ctrls =
self.result3(msgid,all,timeout)
File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line
469, in result3
resp_ctrl_classes=resp_ctrl_classes
File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line
476, in result4
ldap_result =
self._ldap_call(self._l.result4,msgid,all,timeout,add_ctrls,add_intermediates,add_extop)
File "/usr/lib64/python2.7/site-packages/ldap/ldapobject.py", line
99, in _ldap_call
result = func(*args,**kwargs)
OBJECT_CLASS_VIOLATION: {'info': 'missing attribute "ipaRangeType"
required by object class "ipaIDrange"\n', 'desc': 'Object class violation'}
--
Petr³
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
