On Fri, 16 Jan 2015 17:44:12 +0200 Alexander Bokovoy <[email protected]> wrote:
> On Fri, 16 Jan 2015, Simo Sorce wrote: > >On Fri, 16 Jan 2015 10:37:36 +0200 > >Alexander Bokovoy <[email protected]> wrote: > > > >> Hi, > >> > >> attached patch fixes https://fedorahosted.org/freeipa/ticket/4827 > >> > >> It is worth noting that MS-ADTS spec is wrong on this, I'm going to > >> get Microsoft to fix the spec as Windows Server 2012 responds in > >> the same way both on LDAP ping and mailslot ping while > >> documentation insists on them being different. > >> > >> Thanks to Stephan Metzemacher (Samba Team) who noticed we are > >> producing wrong output here. > >> > >> Details are in the patch and in the ticket. > >> > > > >I would prefer to keep the define rather than the new 'pusher' > >variable, other than that it looks good to me. > Updated patch attached. > LGTM! Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
