On 01/19/2015 10:52 AM, Sumit Bose wrote: > On Mon, Jan 19, 2015 at 10:25:34AM +0100, Martin Kosek wrote: >> On 01/16/2015 06:25 PM, Simo Sorce wrote: >>> On Fri, 16 Jan 2015 17:44:12 +0200 >>> Alexander Bokovoy <[email protected]> wrote: >>> >>>> On Fri, 16 Jan 2015, Simo Sorce wrote: >>>>> On Fri, 16 Jan 2015 10:37:36 +0200 >>>>> Alexander Bokovoy <[email protected]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> attached patch fixes https://fedorahosted.org/freeipa/ticket/4827 >>>>>> >>>>>> It is worth noting that MS-ADTS spec is wrong on this, I'm going to >>>>>> get Microsoft to fix the spec as Windows Server 2012 responds in >>>>>> the same way both on LDAP ping and mailslot ping while >>>>>> documentation insists on them being different. >>>>>> >>>>>> Thanks to Stephan Metzemacher (Samba Team) who noticed we are >>>>>> producing wrong output here. >>>>>> >>>>>> Details are in the patch and in the ticket. >>>>>> >>>>> >>>>> I would prefer to keep the define rather than the new 'pusher' >>>>> variable, other than that it looks good to me. >>>> Updated patch attached. >>>> >>> >>> LGTM! >> >> Is that an ACK? :-) It Sumit or anyone else confirms it indeed works, we can >> push... > > I thought it is :-) Nevertheless I had this patch in my tree while > testing Alexander's other patch and didn't see any issues with AD. > > So, since Simo like to code and it passes my tests this is now an ACK.
Ok then - pushed to: master: 5672eb14def7b2010f1d08825eec58ff1444073f ipa-4-1: 426759f47fbef2b902afd975c7bcffc178192ace Thanks, Martin _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
