URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup

lslebodn commented:
"""
You should the opposite of the last patch "Build: clean-up spurious NULL 
variables from Makefile.am files". The NULL should be added to each list.

NACK to the last patch. It does not simplify anything and it makes diff more 
complicated for adding new entries
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/236#issuecomment-259989321
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to