URL: https://github.com/freeipa/freeipa/pull/236
Author: pspacek
 Title: #236: Build phase 7: cleanup
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/236/head:pr236
git checkout pr236
From f9e5691800b5077ffb419674d9c941c758d5352f Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Mon, 14 Nov 2016 08:55:52 +0100
Subject: [PATCH 01/11] Update man page for ipa-adtrust-install by removing
 --no-msdcs option

https://bugzilla.redhat.com/show_bug.cgi?id=1392778
---
 install/tools/man/ipa-adtrust-install.1 | 27 ---------------------------
 1 file changed, 27 deletions(-)

diff --git a/install/tools/man/ipa-adtrust-install.1 b/install/tools/man/ipa-adtrust-install.1
index fbf430a..6e8438b 100644
--- a/install/tools/man/ipa-adtrust-install.1
+++ b/install/tools/man/ipa-adtrust-install.1
@@ -75,33 +75,6 @@ ipa\-adtrust\-install for a second time with a different NetBIOS name will
 change the name. Please note that changing the NetBIOS name might break
 existing trust relationships to other domains.
 .TP
-\fB\-\-no\-msdcs\fR
-Do not create DNS service records for Windows in managed DNS server. Since those
-DNS service records are the only way to discover domain controllers of other
-domains they must be added manually to a different DNS server to allow trust
-realationships work properly. All needed service records are listed when
-ipa\-adtrust\-install finishes and either \-\-no\-msdcs was given or no IPA DNS
-service is configured. Typically service records for the following service names
-are needed for the IPA domain which should point to all IPA servers:
-.IP
-\(bu _ldap._tcp
-.IP
-\(bu _kerberos._tcp
-.IP
-\(bu _kerberos._udp
-.IP
-\(bu _ldap._tcp.dc._msdcs
-.IP
-\(bu _kerberos._tcp.dc._msdcs
-.IP
-\(bu _kerberos._udp.dc._msdcs
-.IP
-\(bu _ldap._tcp.Default-First-Site-Name._sites.dc._msdcs
-.IP
-\(bu _kerberos._tcp.Default-First-Site-Name._sites.dc._msdcs
-.IP
-\(bu _kerberos._udp.Default-First-Site-Name._sites.dc._msdcs
-.TP
 \fB\-\-add\-sids\fR
 Add SIDs to existing users and groups as on of final steps of the
 ipa\-adtrust\-install run. If there a many existing users and groups and a

From 83646d39f4e098860bdca4df219095678da4b354 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Thu, 10 Nov 2016 12:07:03 +0100
Subject: [PATCH 02/11] Build: move client directory handling from SPEC to
 Makefile.am

This is next step towards fully functional make install.

https://fedorahosted.org/freeipa/ticket/6418
---
 client/Makefile.am | 3 +++
 freeipa.spec.in    | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/Makefile.am b/client/Makefile.am
index 0a451e5..4c29ee7 100644
--- a/client/Makefile.am
+++ b/client/Makefile.am
@@ -122,3 +122,6 @@ MAINTAINERCLEANFILES =		\
 	version.m4		\
 	$(NULL)
 
+install-data-hook:
+	$(INSTALL) -d -m 755 $(DESTDIR)$(IPA_SYSCONF_DIR)/nssdb
+	$(INSTALL) -d -m 755 $(DESTDIR)$(localstatedir)/lib/ipa-client/sysrestore
diff --git a/freeipa.spec.in b/freeipa.spec.in
index 7dbbf87..4e39b3c 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -804,11 +804,8 @@ touch %{buildroot}%{_libdir}/krb5/plugins/libkrb5/winbind_krb5_locator.so
 mkdir -p %{buildroot}/%{_localstatedir}/lib/ipa/backup
 %endif # ONLY_CLIENT
 
-mkdir -p %{buildroot}%{_sysconfdir}/ipa/
 /bin/touch %{buildroot}%{_sysconfdir}/ipa/default.conf
 /bin/touch %{buildroot}%{_sysconfdir}/ipa/ca.crt
-mkdir -p %{buildroot}%{_sysconfdir}/ipa/nssdb
-mkdir -p %{buildroot}/%{_localstatedir}/lib/ipa-client/sysrestore
 
 %if ! %{ONLY_CLIENT}
 mkdir -p %{buildroot}%{_sysconfdir}/cron.d

From a2ca9e7ee17e3bc33681f12f739d989af424cba0 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Thu, 10 Nov 2016 12:45:26 +0100
Subject: [PATCH 03/11] Build: move server directory handling from SPEC to
 Makefile.am

This is next step towards fully functional make install.

https://fedorahosted.org/freeipa/ticket/6418
---
 freeipa.spec.in     |  8 --------
 install/Makefile.am | 11 +++++------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 4e39b3c..68fc2bc 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -741,8 +741,6 @@ sed -i -e'1s/python\(3\|$\)/python2/' %{buildroot}%{_bindir}/ipa
 
 %find_lang %{gettext_domain}
 
-mkdir -p %{buildroot}%{_usr}/share/ipa
-
 %if ! %{ONLY_CLIENT}
 # Remove .la files from libtool - we don't want to package
 # these files
@@ -793,7 +791,6 @@ mkdir -p %{buildroot}%{_usr}/share/ipa/html/
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/krb.js
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/krb5.ini
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/krbrealm.con
-mkdir -p %{buildroot}%{_initrddir}
 
 # Web UI plugin dir
 mkdir -p %{buildroot}%{_usr}/share/ipa/ui/js/plugins
@@ -801,7 +798,6 @@ mkdir -p %{buildroot}%{_usr}/share/ipa/ui/js/plugins
 mkdir -p %{buildroot}%{_libdir}/krb5/plugins/libkrb5
 touch %{buildroot}%{_libdir}/krb5/plugins/libkrb5/winbind_krb5_locator.so
 
-mkdir -p %{buildroot}/%{_localstatedir}/lib/ipa/backup
 %endif # ONLY_CLIENT
 
 /bin/touch %{buildroot}%{_sysconfdir}/ipa/default.conf
@@ -818,10 +814,6 @@ mkdir -p %{buildroot}%{_sysconfdir}/cron.d
     sed -e 's,\.py.*$,.*,g' | sort -u | \
     sed -e 's,\./,%%{python_sitelib}/ipatests/,g' ) >tests-python.list
 
-mkdir -p %{buildroot}%{_sysconfdir}/ipa/custodia
-
-mkdir -p %{buildroot}%{_usr}/share/ipa/schema.d
-
 %endif # ONLY_CLIENT
 
 
diff --git a/install/Makefile.am b/install/Makefile.am
index 2dcd927..64219c5 100644
--- a/install/Makefile.am
+++ b/install/Makefile.am
@@ -19,12 +19,11 @@ SUBDIRS =			\
 	$(NULL)
 
 install-exec-local:
-	mkdir -p $(DESTDIR)$(localstatedir)/lib/ipa/sysrestore
-	chmod 700 $(DESTDIR)$(localstatedir)/lib/ipa/sysrestore
-	mkdir -p $(DESTDIR)$(localstatedir)/lib/ipa/sysupgrade
-	chmod 700 $(DESTDIR)$(localstatedir)/lib/ipa/sysupgrade
-	mkdir -p $(DESTDIR)$(localstatedir)/lib/ipa/pki-ca
-	chmod 755 $(DESTDIR)$(localstatedir)/lib/ipa/pki-ca
+	$(INSTALL) -d -m 700 $(DESTDIR)$(IPA_SYSCONF_DIR)/custodia
+	$(INSTALL) -d -m 700 $(DESTDIR)$(localstatedir)/lib/ipa/backup
+	$(INSTALL) -d -m 700 $(DESTDIR)$(localstatedir)/lib/ipa/sysrestore
+	$(INSTALL) -d -m 700 $(DESTDIR)$(localstatedir)/lib/ipa/sysupgrade
+	$(INSTALL) -d -m 755 $(DESTDIR)$(localstatedir)/lib/ipa/pki-ca
 
 uninstall-local:
 	-rmdir $(DESTDIR)$(localstatedir)/lib/ipa/sysrestore

From f7e049453c486e2962d32e793511cd33f6926763 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Thu, 10 Nov 2016 14:39:59 +0100
Subject: [PATCH 04/11] Build: move web UI file installation from SPEC to
 Makefile.am

This is next step towards fully functional make install.

https://fedorahosted.org/freeipa/ticket/6418
---
 freeipa.spec.in          | 19 -------------------
 install/html/Makefile.am | 14 ++++++++++++++
 install/ui/Makefile.am   |  3 +++
 3 files changed, 17 insertions(+), 19 deletions(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 68fc2bc..45d2896 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -763,28 +763,12 @@ rm %{buildroot}/%{plugin_dir}/libtopology.la
 rm %{buildroot}/%{_libdir}/krb5/plugins/kdb/ipadb.la
 rm %{buildroot}/%{_libdir}/samba/pdb/ipasam.la
 
-# Some user-modifiable HTML files are provided. Move these to /etc
-# and link back.
-mkdir -p %{buildroot}/%{_sysconfdir}/ipa/html
-mkdir %{buildroot}%{_usr}/share/ipa/html/
-ln -s ../../../..%{_sysconfdir}/ipa/html/ffconfig.js \
-    %{buildroot}%{_usr}/share/ipa/html/ffconfig.js
-ln -s ../../../..%{_sysconfdir}/ipa/html/ffconfig_page.js \
-    %{buildroot}%{_usr}/share/ipa/html/ffconfig_page.js
-ln -s ../../../..%{_sysconfdir}/ipa/html/ssbrowser.html \
-    %{buildroot}%{_usr}/share/ipa/html/ssbrowser.html
-ln -s ../../../..%{_sysconfdir}/ipa/html/unauthorized.html \
-    %{buildroot}%{_usr}/share/ipa/html/unauthorized.html
-ln -s ../../../..%{_sysconfdir}/ipa/html/browserconfig.html \
-    %{buildroot}%{_usr}/share/ipa/html/browserconfig.html
-
 # So we can own our Apache configuration
 mkdir -p %{buildroot}%{_sysconfdir}/httpd/conf.d/
 /bin/touch %{buildroot}%{_sysconfdir}/httpd/conf.d/ipa.conf
 /bin/touch %{buildroot}%{_sysconfdir}/httpd/conf.d/ipa-kdc-proxy.conf
 /bin/touch %{buildroot}%{_sysconfdir}/httpd/conf.d/ipa-pki-proxy.conf
 /bin/touch %{buildroot}%{_sysconfdir}/httpd/conf.d/ipa-rewrite.conf
-mkdir -p %{buildroot}%{_usr}/share/ipa/html/
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/ca.crt
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/kerberosauth.xpi
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/krb.con
@@ -792,9 +776,6 @@ mkdir -p %{buildroot}%{_usr}/share/ipa/html/
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/krb5.ini
 /bin/touch %{buildroot}%{_usr}/share/ipa/html/krbrealm.con
 
-# Web UI plugin dir
-mkdir -p %{buildroot}%{_usr}/share/ipa/ui/js/plugins
-
 mkdir -p %{buildroot}%{_libdir}/krb5/plugins/libkrb5
 touch %{buildroot}%{_libdir}/krb5/plugins/libkrb5/winbind_krb5_locator.so
 
diff --git a/install/html/Makefile.am b/install/html/Makefile.am
index c487f9f..c65ec26 100644
--- a/install/html/Makefile.am
+++ b/install/html/Makefile.am
@@ -16,3 +16,17 @@ EXTRA_DIST =                            \
 MAINTAINERCLEANFILES =                  \
         *~                              \
         Makefile.in
+
+# Default user-modifiable HTML files are installed into /etc.
+# /usr points to these modifiable files in /etc
+# This is ugly but we do not have time to change it right now.
+# Relative paths must be used to ensure that symlinks created in buildroot
+# work after installation.
+htmldatadir = $(datarootdir)/ipa/html
+install-data-hook:
+	$(INSTALL) -d -m 755 $(DESTDIR)$(htmldatadir)
+	for FILE in $(app_DATA); do				\
+		$(LN_S) --force --relative			\
+			$(DESTDIR)$(appdir)/$${FILE}		\
+			$(DESTDIR)$(htmldatadir)/$${FILE};	\
+	done
diff --git a/install/ui/Makefile.am b/install/ui/Makefile.am
index 18fb9b4..c81eceb 100644
--- a/install/ui/Makefile.am
+++ b/install/ui/Makefile.am
@@ -34,3 +34,6 @@ MAINTAINERCLEANFILES =                  \
         *~                              \
         Makefile.in
 	$(NULL)
+
+install-data-hook:
+	$(INSTALL) -d -m 755 $(DESTDIR)$(appdir)/js/plugins

From fe513b580d9ff2b21d98853b9f1f4d647650a879 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 11 Nov 2016 12:21:58 +0100
Subject: [PATCH 05/11] Build: document what should be in %install section of
 SPEC file

https://fedorahosted.org/freeipa/ticket/6418
---
 freeipa.spec.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 45d2896..b552dcd 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -702,6 +702,14 @@ make %{?_smp_mflags} client-check VERBOSE=yes LIBDIR=%{_libdir}
 
 
 %install
+# Please put as much logic as possible into make install. It allows:
+# - easier porting to other distributions
+# - rapid devel & install cycle using make install
+#   (instead of full RPM build and installation each time)
+#
+# All files and directories created by spec install should be marked as ghost.
+# (These are typically configuration files created by IPA installer.)
+# All other artifacts should be created by make install.
 %make_install
 # remove files which are useful only for make uninstall
 find %{buildroot} -wholename '*/site-packages/*/install_files.txt' -exec rm {} \;

From df5720113b8117de585e1c127ad2121fcbca6a2b Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Thu, 10 Nov 2016 15:24:50 +0100
Subject: [PATCH 06/11] Build: workaround bug 1005235 related to Python paths
 in auto-generated Requires

https://fedorahosted.org/freeipa/ticket/6418
---
 freeipa.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index b552dcd..6cacbac 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -689,6 +689,8 @@ This package contains tests that verify IPA functionality under Python 3.
 %build
 # UI compilation segfaulted on some arches when the stack was lower (#1040576)
 export JAVA_STACK_SIZE="8m"
+# PATH is workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1005235
+export PATH=/usr/bin:/usr/sbin:$PATH
 %configure --with-vendor-suffix=-%{release}
 %make_build
 

From bd98ce0976dec9c48f0125099118380e829266f2 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 11 Nov 2016 12:37:03 +0100
Subject: [PATCH 07/11] Build: support --enable-silent-rules for Python
 packages

Setuptools will print only warnings. The option has to be used before
setuptools command specification, otherwise it will not apply to sub-commands.

https://fedorahosted.org/freeipa/ticket/6418
---
 Makefile.python.am | 20 ++++++++++++++------
 configure.ac       |  2 ++
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/Makefile.python.am b/Makefile.python.am
index 0ea3fcf..c9c1a1f 100644
--- a/Makefile.python.am
+++ b/Makefile.python.am
@@ -1,18 +1,26 @@
 pkgname = $(shell basename "$(abs_srcdir)")
 pkgpythondir = $(pythondir)/$(pkgname)
 
+if VERBOSE_MAKE
+VERBOSITY="--verbose"
+else
+VERBOSITY="--quiet"
+endif !VERBOSE_MAKE
+
 all-local:
-	cd $(srcdir); $(PYTHON) setup.py build \
-	--build-base "$(abs_builddir)/build" \
-	--verbose
+	cd $(srcdir); $(PYTHON) setup.py \
+		$(VERBOSITY) \
+		build \
+		--build-base "$(abs_builddir)/build"
 
 install-exec-local:
-	$(PYTHON) $(srcdir)/setup.py install \
+	$(PYTHON) $(srcdir)/setup.py \
+		$(VERBOSITY) \
+		install \
 		--prefix "$(DESTDIR)$(prefix)" \
 		--single-version-externally-managed \
 		--record "$(DESTDIR)$(pkgpythondir)/install_files.txt" \
-		--optimize 1 \
-		--verbose
+		--optimize 1
 
 uninstall-local:
 	cat "$(DESTDIR)$(pkgpythondir)/install_files.txt" | xargs rm -rf
diff --git a/configure.ac b/configure.ac
index 4d0b09c..b042455 100644
--- a/configure.ac
+++ b/configure.ac
@@ -419,6 +419,8 @@ else
         AC_MSG_RESULT(no)
 fi
 
+AM_CONDITIONAL([VERBOSE_MAKE], [test "x${AM_DEFAULT_VERBOSITY}" == "x1"])
+
 dnl ---------------------------------------------------------------------------
 dnl Linters
 dnl ---------------------------------------------------------------------------

From 85d55126f99fc1b5fcaa3eb926143adb87c851d2 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 11 Nov 2016 12:46:00 +0100
Subject: [PATCH 08/11] Build: enable silent build in makerpms.sh

Build called from makerpms.sh is not verbose by default anymore.
It still prints all directories and files it builds but the long
command lines are hidden by default.

It has the advantage that compiler and other warnings are visible to
developers right away. If you need to debug something,
use --disable-silent-rules to override the default
(or call configure manually).

https://fedorahosted.org/freeipa/ticket/6418
---
 makerpms.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/makerpms.sh b/makerpms.sh
index 775d18f..ee6ba8a 100755
--- a/makerpms.sh
+++ b/makerpms.sh
@@ -4,7 +4,7 @@ set -o errexit
 pushd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 test ! -x "configure" && autoreconf -i
-test ! -f "Makefile" && ./configure "$@"
+test ! -f "Makefile" && ./configure --enable-silent-rules "$@"
 make rpms
 
 popd

From 0ba29a4feca73c24d80026122605bdbfdf5f10d6 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 11 Nov 2016 14:37:18 +0100
Subject: [PATCH 09/11] Build: remove incorrect use of MAINTAINERCLEANFILES

Automake manual section 13 What Gets Cleaned says that make maintainer-clean
should not remove files necessary for subsequent runs of ./configure.

It practically means that all usage of MAINTAINERCLEANFILES were incorrect
so I've removed them.

https://fedorahosted.org/freeipa/ticket/6418
---
 client/Makefile.am                                 | 23 --------------------
 client/man/Makefile.am                             |  6 ------
 daemons/Makefile.am                                | 25 ----------------------
 daemons/ipa-kdb/Makefile.am                        |  4 ----
 daemons/ipa-sam/Makefile.am                        |  4 ----
 daemons/ipa-slapi-plugins/Makefile.am              |  4 ----
 daemons/ipa-slapi-plugins/ipa-cldap/Makefile.am    |  4 ----
 daemons/ipa-slapi-plugins/ipa-dns/Makefile.am      |  4 ----
 .../ipa-slapi-plugins/ipa-enrollment/Makefile.am   |  4 ----
 .../ipa-slapi-plugins/ipa-extdom-extop/Makefile.am |  4 ----
 daemons/ipa-slapi-plugins/ipa-lockout/Makefile.am  |  4 ----
 daemons/ipa-slapi-plugins/ipa-modrdn/Makefile.am   |  4 ----
 .../ipa-slapi-plugins/ipa-otp-counter/Makefile.am  |  1 -
 .../ipa-otp-lasttoken/Makefile.am                  |  1 -
 .../ipa-slapi-plugins/ipa-pwd-extop/Makefile.am    |  1 -
 .../ipa-slapi-plugins/ipa-range-check/Makefile.am  |  4 ----
 daemons/ipa-slapi-plugins/ipa-sidgen/Makefile.am   |  4 ----
 daemons/ipa-slapi-plugins/ipa-uuid/Makefile.am     |  4 ----
 daemons/ipa-slapi-plugins/ipa-version/Makefile.am  |  4 ----
 daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am  |  4 ----
 daemons/ipa-slapi-plugins/libotp/Makefile.am       |  1 -
 daemons/ipa-slapi-plugins/topology/Makefile.am     |  4 ----
 install/Makefile.am                                | 25 ----------------------
 install/certmonger/Makefile.am                     |  4 ----
 install/conf/Makefile.am                           |  4 ----
 install/html/Makefile.am                           |  4 ----
 install/migration/Makefile.am                      |  4 ----
 install/oddjob/Makefile.am                         |  4 ----
 install/restart_scripts/Makefile.am                |  4 ----
 install/share/Makefile.am                          |  4 ----
 install/share/advise/Makefile.am                   |  4 ----
 install/share/advise/legacy/Makefile.am            |  4 ----
 install/share/profiles/Makefile.am                 |  4 ----
 install/share/schema.d/Makefile.am                 |  4 ----
 install/tools/Makefile.am                          |  4 ----
 install/tools/man/Makefile.am                      |  4 ----
 install/ui/Makefile.am                             |  5 -----
 install/ui/build/Makefile.am                       |  5 -----
 install/ui/build/dojo/Makefile.am                  |  4 ----
 install/ui/build/freeipa/Makefile.am               |  4 ----
 install/ui/css/Makefile.am                         |  4 ----
 install/ui/images/Makefile.am                      |  4 ----
 install/ui/src/Makefile.am                         |  5 -----
 install/ui/src/libs/Makefile.am                    |  4 ----
 install/updates/Makefile.am                        |  4 ----
 install/wsgi/Makefile.am                           |  4 ----
 ipatests/man/Makefile.am                           |  4 ----
 47 files changed, 242 deletions(-)

diff --git a/client/Makefile.am b/client/Makefile.am
index 4c29ee7..b6c9dea 100644
--- a/client/Makefile.am
+++ b/client/Makefile.am
@@ -99,29 +99,6 @@ EXTRA_DIST =			\
 	$(sbin_SCRIPTS)		\
 	$(NULL)
 
-DISTCLEANFILES =		\
-	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	intltool-*.in		\
-	compile			\
-	configure		\
-	COPYING			\
-	INSTALL			\
-	install-sh		\
-	missing			\
-	mkinstalldirs		\
-	config.guess		\
-	ltmain.sh		\
-	config.sub		\
-	depcomp			\
-	Makefile.in		\
-	config.h.*		\
-	aclocal.m4		\
-	version.m4		\
-	$(NULL)
-
 install-data-hook:
 	$(INSTALL) -d -m 755 $(DESTDIR)$(IPA_SYSCONF_DIR)/nssdb
 	$(INSTALL) -d -m 755 $(DESTDIR)$(localstatedir)/lib/ipa-client/sysrestore
diff --git a/client/man/Makefile.am b/client/man/Makefile.am
index fbee4d3..566c429 100644
--- a/client/man/Makefile.am
+++ b/client/man/Makefile.am
@@ -2,8 +2,6 @@
 
 AUTOMAKE_OPTIONS = 1.7
 
-NULL =
-
 dist_man1_MANS =			\
 		ipa-getkeytab.1		\
 		ipa-rmkeytab.1		\
@@ -15,7 +13,3 @@ dist_man1_MANS =			\
 
 dist_man5_MANS =			\
 		default.conf.5
-
-MAINTAINERCLEANFILES =          \
-	Makefile.in		\
-	$(NULL)
diff --git a/daemons/Makefile.am b/daemons/Makefile.am
index 7ae7b3c..a3d4d1d 100644
--- a/daemons/Makefile.am
+++ b/daemons/Makefile.am
@@ -19,28 +19,3 @@ SUBDIRS =			\
 	ipa-sam			\
 	ipa-otpd		\
 	$(NULL)
-
-DISTCLEANFILES =		\
-	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	intltool-*.in		\
-	compile			\
-	configure		\
-	COPYING			\
-	INSTALL			\
-	install-sh		\
-	missing			\
-	mkinstalldirs		\
-	config.guess		\
-	ltmain.sh		\
-	config.sub		\
-	depcomp			\
-	Makefile.in		\
-	config.h.*		\
-	aclocal.m4		\
-	version.m4		\
-	ipa-client.spec		\
-	py-compile		\
-	$(NULL)
diff --git a/daemons/ipa-kdb/Makefile.am b/daemons/ipa-kdb/Makefile.am
index 2b46e00..19583c9 100644
--- a/daemons/ipa-kdb/Makefile.am
+++ b/daemons/ipa-kdb/Makefile.am
@@ -89,7 +89,3 @@ EXTRA_DIST =			\
 	README			\
 	README.s4u2proxy.txt	\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-sam/Makefile.am b/daemons/ipa-sam/Makefile.am
index 790e175..2f90467 100644
--- a/daemons/ipa-sam/Makefile.am
+++ b/daemons/ipa-sam/Makefile.am
@@ -60,7 +60,3 @@ EXTRA_DIST =			\
 	README			\
 	ipa_sam.h		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/Makefile.am b/daemons/ipa-slapi-plugins/Makefile.am
index 0ab45ac..216b2ad 100644
--- a/daemons/ipa-slapi-plugins/Makefile.am
+++ b/daemons/ipa-slapi-plugins/Makefile.am
@@ -25,7 +25,3 @@ noinst_HEADERS =		\
 EXTRA_DIST =			\
 	README			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-cldap/Makefile.am b/daemons/ipa-slapi-plugins/ipa-cldap/Makefile.am
index 037c0fc..f299b70 100644
--- a/daemons/ipa-slapi-plugins/ipa-cldap/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-cldap/Makefile.am
@@ -61,7 +61,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-dns/Makefile.am b/daemons/ipa-slapi-plugins/ipa-dns/Makefile.am
index f8f28d6..099708c 100644
--- a/daemons/ipa-slapi-plugins/ipa-dns/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-dns/Makefile.am
@@ -38,7 +38,3 @@ app_DATA =          \
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-enrollment/Makefile.am b/daemons/ipa-slapi-plugins/ipa-enrollment/Makefile.am
index 34b5cb7..4ce32c4 100644
--- a/daemons/ipa-slapi-plugins/ipa-enrollment/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-enrollment/Makefile.am
@@ -38,7 +38,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-extdom-extop/Makefile.am b/daemons/ipa-slapi-plugins/ipa-extdom-extop/Makefile.am
index a426353..c9f74f0 100644
--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/Makefile.am
@@ -70,7 +70,3 @@ EXTRA_DIST =			\
 	test_data		\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-lockout/Makefile.am b/daemons/ipa-slapi-plugins/ipa-lockout/Makefile.am
index 89b5093..8d8c975 100644
--- a/daemons/ipa-slapi-plugins/ipa-lockout/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-lockout/Makefile.am
@@ -38,7 +38,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-modrdn/Makefile.am b/daemons/ipa-slapi-plugins/ipa-modrdn/Makefile.am
index 51feb5b..8efa155 100644
--- a/daemons/ipa-slapi-plugins/ipa-modrdn/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-modrdn/Makefile.am
@@ -38,7 +38,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-otp-counter/Makefile.am b/daemons/ipa-slapi-plugins/ipa-otp-counter/Makefile.am
index 34fd778..dee3845 100644
--- a/daemons/ipa-slapi-plugins/ipa-otp-counter/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-otp-counter/Makefile.am
@@ -1,4 +1,3 @@
-MAINTAINERCLEANFILES = *~ Makefile.in
 PLUGIN_COMMON_DIR = $(srcdir)/../common
 AM_CPPFLAGS =							\
 	-I$(srcdir)						\
diff --git a/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/Makefile.am b/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/Makefile.am
index 8c2bf3d..e98e696 100644
--- a/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/Makefile.am
@@ -1,4 +1,3 @@
-MAINTAINERCLEANFILES = *~ Makefile.in
 PLUGIN_COMMON_DIR = $(srcdir)/../common
 AM_CPPFLAGS =							\
 	-I$(srcdir)						\
diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/Makefile.am b/daemons/ipa-slapi-plugins/ipa-pwd-extop/Makefile.am
index f9e32d9..43c99d9 100644
--- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/Makefile.am
@@ -1,6 +1,5 @@
 NULL =
 
-MAINTAINERCLEANFILES = *~ Makefile.in
 PLUGIN_COMMON_DIR = $(srcdir)/../common
 
 AM_CPPFLAGS =							\
diff --git a/daemons/ipa-slapi-plugins/ipa-range-check/Makefile.am b/daemons/ipa-slapi-plugins/ipa-range-check/Makefile.am
index bf7b1f2..b9abc4a 100644
--- a/daemons/ipa-slapi-plugins/ipa-range-check/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-range-check/Makefile.am
@@ -38,7 +38,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-sidgen/Makefile.am b/daemons/ipa-slapi-plugins/ipa-sidgen/Makefile.am
index 60c63ea..a672e21 100644
--- a/daemons/ipa-slapi-plugins/ipa-sidgen/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-sidgen/Makefile.am
@@ -56,7 +56,3 @@ app_DATA =				\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-uuid/Makefile.am b/daemons/ipa-slapi-plugins/ipa-uuid/Makefile.am
index ac86dd4..540325e 100644
--- a/daemons/ipa-slapi-plugins/ipa-uuid/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-uuid/Makefile.am
@@ -39,7 +39,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-version/Makefile.am b/daemons/ipa-slapi-plugins/ipa-version/Makefile.am
index 686c958..21bf9c2 100644
--- a/daemons/ipa-slapi-plugins/ipa-version/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-version/Makefile.am
@@ -40,7 +40,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am b/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am
index 0b32b84..3ac572d 100644
--- a/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am
+++ b/daemons/ipa-slapi-plugins/ipa-winsync/Makefile.am
@@ -40,7 +40,3 @@ EXTRA_DIST =			\
 	README			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/daemons/ipa-slapi-plugins/libotp/Makefile.am b/daemons/ipa-slapi-plugins/libotp/Makefile.am
index 35e8d2a..3a89a67 100644
--- a/daemons/ipa-slapi-plugins/libotp/Makefile.am
+++ b/daemons/ipa-slapi-plugins/libotp/Makefile.am
@@ -1,4 +1,3 @@
-MAINTAINERCLEANFILES = *~ Makefile.in
 PLUGIN_COMMON_DIR = $(srcdir)/../common
 AM_CPPFLAGS = -I/usr/include/dirsrv		\
 	-I$(PLUGIN_COMMON_DIR)
diff --git a/daemons/ipa-slapi-plugins/topology/Makefile.am b/daemons/ipa-slapi-plugins/topology/Makefile.am
index 11fb02a..1d86bd0 100644
--- a/daemons/ipa-slapi-plugins/topology/Makefile.am
+++ b/daemons/ipa-slapi-plugins/topology/Makefile.am
@@ -44,7 +44,3 @@ app_DATA =			\
 EXTRA_DIST =			\
 	$(app_DATA)		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/install/Makefile.am b/install/Makefile.am
index 64219c5..845e751 100644
--- a/install/Makefile.am
+++ b/install/Makefile.am
@@ -31,28 +31,3 @@ uninstall-local:
 	-rmdir $(DESTDIR)$(localstatedir)/lib/ipa
 
 EXTRA_DIST = README.schema
-
-DISTCLEANFILES =		\
-	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	intltool-*.in		\
-	compile			\
-	configure		\
-	COPYING			\
-	INSTALL			\
-	install-sh		\
-	missing			\
-	mkinstalldirs		\
-	config.guess		\
-	ltmain.sh		\
-	config.sub		\
-	depcomp			\
-	Makefile.in		\
-	config.h.*		\
-	aclocal.m4		\
-	version.m4		\
-	ipa-client.spec		\
-	py-compile		\
-	$(NULL)
diff --git a/install/certmonger/Makefile.am b/install/certmonger/Makefile.am
index 2dc476f..63fd577 100644
--- a/install/certmonger/Makefile.am
+++ b/install/certmonger/Makefile.am
@@ -9,7 +9,3 @@ app_SCRIPTS =					\
 EXTRA_DIST =				\
 	$(app_SCRIPTS)			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/conf/Makefile.am b/install/conf/Makefile.am
index 5daac77..751bb16 100644
--- a/install/conf/Makefile.am
+++ b/install/conf/Makefile.am
@@ -11,7 +11,3 @@ app_DATA =                              \
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
diff --git a/install/html/Makefile.am b/install/html/Makefile.am
index c65ec26..3b7a064 100644
--- a/install/html/Makefile.am
+++ b/install/html/Makefile.am
@@ -13,10 +13,6 @@ EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
 
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
-
 # Default user-modifiable HTML files are installed into /etc.
 # /usr points to these modifiable files in /etc
 # This is ugly but we do not have time to change it right now.
diff --git a/install/migration/Makefile.am b/install/migration/Makefile.am
index b905780..4d22de5 100644
--- a/install/migration/Makefile.am
+++ b/install/migration/Makefile.am
@@ -11,7 +11,3 @@ app_DATA =                              \
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
diff --git a/install/oddjob/Makefile.am b/install/oddjob/Makefile.am
index a477ed3..1dbd8fa 100644
--- a/install/oddjob/Makefile.am
+++ b/install/oddjob/Makefile.am
@@ -18,7 +18,3 @@ dist_oddjobconf_DATA =					\
 	etc/oddjobd.conf.d/oddjobd-ipa-trust.conf	\
 	etc/oddjobd.conf.d/ipa-server.conf		\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/restart_scripts/Makefile.am b/install/restart_scripts/Makefile.am
index dd949a9..04881b4 100644
--- a/install/restart_scripts/Makefile.am
+++ b/install/restart_scripts/Makefile.am
@@ -13,7 +13,3 @@ app_DATA =                              \
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
diff --git a/install/share/Makefile.am b/install/share/Makefile.am
index 776aaab..10de84d 100644
--- a/install/share/Makefile.am
+++ b/install/share/Makefile.am
@@ -90,7 +90,3 @@ dist_app_DATA =				\
 kdcproxyconfdir = $(IPA_SYSCONF_DIR)/kdcproxy
 dist_kdcproxyconf_DATA =			\
 	kdcproxy.conf
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/share/advise/Makefile.am b/install/share/advise/Makefile.am
index 877f91c..6d2a99b 100644
--- a/install/share/advise/Makefile.am
+++ b/install/share/advise/Makefile.am
@@ -11,7 +11,3 @@ app_DATA =				\
 EXTRA_DIST =				\
 	$(app_DATA)			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/share/advise/legacy/Makefile.am b/install/share/advise/legacy/Makefile.am
index 4121851..d238b29 100644
--- a/install/share/advise/legacy/Makefile.am
+++ b/install/share/advise/legacy/Makefile.am
@@ -11,7 +11,3 @@ app_DATA =				\
 EXTRA_DIST =				\
 	$(app_DATA)			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/share/profiles/Makefile.am b/install/share/profiles/Makefile.am
index b5ccb6e..d1c1bac 100644
--- a/install/share/profiles/Makefile.am
+++ b/install/share/profiles/Makefile.am
@@ -9,7 +9,3 @@ app_DATA =				\
 EXTRA_DIST =				\
 	$(app_DATA)			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/share/schema.d/Makefile.am b/install/share/schema.d/Makefile.am
index 0fef87f..6cd554e 100644
--- a/install/share/schema.d/Makefile.am
+++ b/install/share/schema.d/Makefile.am
@@ -10,7 +10,3 @@ app_DATA = README			\
 EXTRA_DIST =				\
 	$(app_DATA)			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/tools/Makefile.am b/install/tools/Makefile.am
index a440bcc..74f428e 100644
--- a/install/tools/Makefile.am
+++ b/install/tools/Makefile.am
@@ -36,7 +36,3 @@ dist_app_SCRIPTS =		\
 	ipa-httpd-kdcproxy	\
 	ipa-pki-retrieve-key	\
 	$(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/install/tools/man/Makefile.am b/install/tools/man/Makefile.am
index d2b3195..b1fba6d 100644
--- a/install/tools/man/Makefile.am
+++ b/install/tools/man/Makefile.am
@@ -33,7 +33,3 @@ dist_man8_MANS =			\
 	ipactl.8			\
 	ipa-upgradeconfig.8		\
         $(NULL)
-
-MAINTAINERCLEANFILES =          \
-        Makefile.in             \
-        $(NULL)
diff --git a/install/ui/Makefile.am b/install/ui/Makefile.am
index c81eceb..7733958 100644
--- a/install/ui/Makefile.am
+++ b/install/ui/Makefile.am
@@ -30,10 +30,5 @@ EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
 
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
-	$(NULL)
-
 install-data-hook:
 	$(INSTALL) -d -m 755 $(DESTDIR)$(appdir)/js/plugins
diff --git a/install/ui/build/Makefile.am b/install/ui/build/Makefile.am
index 0787e7f..33a3ade 100644
--- a/install/ui/build/Makefile.am
+++ b/install/ui/build/Makefile.am
@@ -9,8 +9,3 @@ SUBDIRS =  				\
 
 EXTRA_DIST =                            \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
-	$(NULL)
diff --git a/install/ui/build/dojo/Makefile.am b/install/ui/build/dojo/Makefile.am
index 666a49a..2df5f69 100644
--- a/install/ui/build/dojo/Makefile.am
+++ b/install/ui/build/dojo/Makefile.am
@@ -8,7 +8,3 @@ app_DATA =				\
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
diff --git a/install/ui/build/freeipa/Makefile.am b/install/ui/build/freeipa/Makefile.am
index 35a3181..05e82f4 100644
--- a/install/ui/build/freeipa/Makefile.am
+++ b/install/ui/build/freeipa/Makefile.am
@@ -12,10 +12,6 @@ EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
 
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
-
 core := $(wildcard ../../src/freeipa/*.js)
 base := $(wildcard ../../src/freeipa/_base/*.js)
 widgets := $(wildcard ../../src/freeipa/widgets/*.js)
diff --git a/install/ui/css/Makefile.am b/install/ui/css/Makefile.am
index 2543145..3cc6968 100644
--- a/install/ui/css/Makefile.am
+++ b/install/ui/css/Makefile.am
@@ -15,10 +15,6 @@ EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
 
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
-
 ipa := $(wildcard ../less/*.less)
 
 ipa.css: $(ipa)
diff --git a/install/ui/images/Makefile.am b/install/ui/images/Makefile.am
index 7d85d7e..f922fd0 100644
--- a/install/ui/images/Makefile.am
+++ b/install/ui/images/Makefile.am
@@ -13,7 +13,3 @@ app_DATA =                              \
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
diff --git a/install/ui/src/Makefile.am b/install/ui/src/Makefile.am
index 4c70ba1..6182b7b 100644
--- a/install/ui/src/Makefile.am
+++ b/install/ui/src/Makefile.am
@@ -11,8 +11,3 @@ EXTRA_DIST =                            \
 	dojo.profile.js			\
 	freeipa				\
 	webui.profile.js
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
-	$(NULL)
diff --git a/install/ui/src/libs/Makefile.am b/install/ui/src/libs/Makefile.am
index 1962c41..f5a9e0e 100644
--- a/install/ui/src/libs/Makefile.am
+++ b/install/ui/src/libs/Makefile.am
@@ -19,7 +19,3 @@ nodist_app_DATA =			\
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =                  \
-        *~                              \
-        Makefile.in
diff --git a/install/updates/Makefile.am b/install/updates/Makefile.am
index b1177d8..a80256f 100644
--- a/install/updates/Makefile.am
+++ b/install/updates/Makefile.am
@@ -66,7 +66,3 @@ app_DATA =				\
 EXTRA_DIST =				\
 	$(app_DATA)			\
 	$(NULL)
-
-MAINTAINERCLEANFILES =			\
-	*~				\
-	Makefile.in
diff --git a/install/wsgi/Makefile.am b/install/wsgi/Makefile.am
index a6211d6..f5f0f11 100644
--- a/install/wsgi/Makefile.am
+++ b/install/wsgi/Makefile.am
@@ -8,7 +8,3 @@ app_DATA =                              \
 EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
-
-MAINTAINERCLEANFILES =		\
-	*~			\
-	Makefile.in
diff --git a/ipatests/man/Makefile.am b/ipatests/man/Makefile.am
index 6b79128..6d66699 100644
--- a/ipatests/man/Makefile.am
+++ b/ipatests/man/Makefile.am
@@ -9,7 +9,3 @@ dist_man1_MANS =            \
 	ipa-test-config.1   \
 	ipa-test-task.1     \
 		$(NULL)
-
-MAINTAINERCLEANFILES =      \
-	Makefile.in             \
-	$(NULL)

From cc0918a44c26caa083ff36446499c2a624f337ea Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 11 Nov 2016 15:32:29 +0100
Subject: [PATCH 10/11] Build: update makerpms.sh to use same paths as rpmbuild

This allows us to simply use makerpms.sh to configure the build tree,
install RPMs to configure system for the first time and then use make install
for rapid devel/test cycles.

Configuration parameteres were taken from rpm-4.13.0-0.rc1.27.fc24.x86_64.

https://fedorahosted.org/freeipa/ticket/6418
---
 makerpms.sh | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/makerpms.sh b/makerpms.sh
index ee6ba8a..bdf0231 100755
--- a/makerpms.sh
+++ b/makerpms.sh
@@ -4,7 +4,26 @@ set -o errexit
 pushd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 test ! -x "configure" && autoreconf -i
-test ! -f "Makefile" && ./configure --enable-silent-rules "$@"
+# run configure with the same parameters as RPM build
+# this makes it easy to tweak files locally and use make install
+test ! -f "Makefile" && ./configure --enable-silent-rules \
+	--host=$(rpm -E %{_host}) \
+	--build=$(rpm -E %{_build}) \
+	--program-prefix=$(rpm -E %{?_program_prefix}) \
+	--prefix=$(rpm -E %{_prefix}) \
+	--exec-prefix=$(rpm -E %{_exec_prefix}) \
+	--bindir=$(rpm -E %{_bindir}) \
+	--sbindir=$(rpm -E %{_sbindir}) \
+	--sysconfdir=$(rpm -E %{_sysconfdir}) \
+	--datadir=$(rpm -E %{_datadir}) \
+	--includedir=$(rpm -E %{_includedir}) \
+	--libdir=$(rpm -E %{_libdir}) \
+	--libexecdir=$(rpm -E %{_libexecdir}) \
+	--localstatedir=$(rpm -E %{_localstatedir}) \
+	--sharedstatedir=$(rpm -E %{_sharedstatedir}) \
+	--mandir=$(rpm -E %{_mandir}) \
+	--infodir=$(rpm -E %{_infodir}) \
+	"$@"
 make rpms
 
 popd

From 28b692b7633d0e26973f0b20c0f1c6ac7c08c889 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 11 Nov 2016 15:43:14 +0100
Subject: [PATCH 11/11] Build: fix file dependencies for make-css.sh

Some of .less files included by ipa.less were not listed in the
Makefile.am so some changes might not trigger rebuild.

https://fedorahosted.org/freeipa/ticket/6418
---
 install/ui/css/Makefile.am | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/install/ui/css/Makefile.am b/install/ui/css/Makefile.am
index 3cc6968..33dc51e 100644
--- a/install/ui/css/Makefile.am
+++ b/install/ui/css/Makefile.am
@@ -15,7 +15,11 @@ EXTRA_DIST =                            \
         $(app_DATA)                     \
         $(NULL)
 
-ipa := $(wildcard ../less/*.less)
+ipa := $(wildcard ../less/*.less)		\
+	../less/font-awesome/variables.less	\
+	../less/patternfly/variables.less	\
+	../less/bootstrap/variables.less	\
+	../less/variables.less
 
 ipa.css: $(ipa)
 	$(srcdir)/../util/make-css.sh
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to