On Wed, 27 Dec 2000, Scott Gregory Miller wrote:
> On Wed, 27 Dec 2000, Scott Gregory Miller wrote:
>
> > >
> > > To add support for MSKs to RequestClient, the obvious place to add it is
> > > ClientUtil.getKey, but I would have to overload it with another version
> > > that takes a MapHandler as an argument, and that's ugly and inefficient,
> > > because the key might not even be a MSK. So I could add a isMSK method to
> > > ClientUtil that takes the key string and checks. I'd do it in fillBuckets
> > > before the ClientKey is initialized, and if it returns true, I'd
> > > instantiate a MapHandler and run the key string through it first.
> >
> > I don't think having a MapHandler as an argument to ClientUtil.getKey is
> *isn't* too terrible, my bad.
I said it was ugly and inefficient!
I need to pass it a Params object because the MapHandler needs to request
the mapfile. Otherwise I can leave getKey alone and do it right in
fillBuckets. Either way is OK IMHO. It's only two lines of code.
--
Mark Roberts
[EMAIL PROTECTED]
_______________________________________________
Freenet-dev mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/mailman/listinfo/freenet-dev
