On Sat, 8 May 2004, Mark Constable wrote: > I'm just starting out with changing over from xtRadius to > freeRadius and testing things for the next few days. I'll be > looking hard at dialup_admin and just now I've got it up on > my own test box and I can see there are a few basic and obvious > mods that could be made... that I will be doing anyway, and > more, for myself but could be of general interest. > > . I'd be prepared to find every instance of *.php3 > and change then _ALL_ to just *.php
Hmm ok, but in any case it's mostly a cosmetic change. > . change all $HTTP_*_VARS to just $_SERVER etc dialupadmin should use the new variable format in general. I was just waiting for everyone to be using newer versions of PHP. It's much better from a security point of view. > . catch all missing isset($var) warnings That would be nice. > . ensure error_reporting(E_ALL) compatible > . ensure it runs under PHP5 (my test system) > > Are these changes of any use to anyone else and if so how > could I go about supplying the changes to whoever wants them ? Make the changes and open a bug report to bugs.freeradius with the patch. Preferably the .php3 -> .php patch should be kept separate. > > --markc > > - > List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html > -- Kostas Kalevras Network Operations Center [EMAIL PROTECTED] National Technical University of Athens, Greece Work Phone: +30 210 7721861 'Go back to the shadow' Gandalf - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html