Thanks Alex, I added that scaling for the out of sync case. I'm glad the API worked out for you. I'll be adding new HF modes and a VHF mode over the next few months.
What sort of hardware/SDR setup do you have? Thanks, David On 20/12/14 09:17, Alexandru Csete wrote: > Hi David, > > Thanks for the update. With these latest changes I no longer observe > the issue I was having. I'll do more testing over the next weeks as I > integrate freedv with my hardware and SDR setups. The freedv_api is > really great and easy to use. > > I did notice a small issue though. At the end of freedv_floatrx() when > there is no sync, the samples in demod_in[] are not scaled back with > FDMDV_SCALE. > > Alex > > > > On Thu, Dec 18, 2014 at 12:55 PM, David Rowe <[email protected]> wrote: >> Hi, >> >> I haven't been able to repeat this problem or find the root cause. >> >> However I have added some code to trap the problem (an assert in >> golay23_decode()), and some code to help prevent invalid codewords being >> built up in freedv_floatrx(). >> >> It's tested with freedv_tx/freedv_rx, and checked into codec2-dev SVN. >> >> Cheers, >> >> David >> >> On 18/12/14 20:33, Alexandru Csete wrote: >>> On Sat, Aug 9, 2014 at 11:52 PM, Bruce Perens <[email protected]> wrote: >>>> David, >>>> >>>> golay23_decode() overruns a table once in a while because the unpacked >>>> bit array has garbage in it. Some value is greater than 1 and the input >>>> code word ends up negative. I ran Valgrind to see if it was a problem in >>>> my code, and didn't see any wild memory references, but I do get >>>> uninitialized data as input to a conditional switch complaints as >>>> detailed in my last email. >>> >>> Greetings, >>> >>> I have run into this same issue few days ago while using the >>> freedv_api. On one computer running 64 bit linux and gcc 4.8 I didn't >>> have this issue. On another one running 32 bit linux and gcc 4.9 it >>> happened every time after running the application for a few seconds. >>> Perhaps it also depends on optimization level. >>> >>> I worked around it by using calloc instead of malloc for allocating >>> tx_bits and rx_bits, though it seems that the problem is somewhere >>> else. >>> >>> Alex >>> >>> ------------------------------------------------------------------------------ >>> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server >>> from Actuate! Instantly Supercharge Your Business Reports and Dashboards >>> with Interactivity, Sharing, Native Excel Exports, App Integration & more >>> Get technology previously reserved for billion-dollar corporations, FREE >>> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> Freetel-codec2 mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/freetel-codec2 >>> >> >> ------------------------------------------------------------------------------ >> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server >> from Actuate! Instantly Supercharge Your Business Reports and Dashboards >> with Interactivity, Sharing, Native Excel Exports, App Integration & more >> Get technology previously reserved for billion-dollar corporations, FREE >> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk >> _______________________________________________ >> Freetel-codec2 mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/freetel-codec2 > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk > _______________________________________________ > Freetel-codec2 mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freetel-codec2 > ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Freetel-codec2 mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freetel-codec2
