Hi Richard,

one issue we've had around this sort of code is breaking the Pi (or even
OSX) build.  It would be good to automate that on Travis somehow.

Cheers,
David

On 24/5/20 5:00 am, Mooneer Salem wrote:
> The code that uses cpuid is supposed to be #ifdef'd with the following:
> 
> #if defined(__x86_64__) || defined(_M_X64) || defined(__i386) ||
> defined(_M_IX86)
> 
> Seems weird that a non-x86 would cause that stuff to attempt to be
> compiled in anyway. Would explicitly adding something like
> !defined(__arm__) help?
> 
> -Mooneer 
> 
> On Sat, May 23, 2020 at 6:56 AM Richard Shaw <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     So I'm working on updating Fedora to FreeDV 1.4+codec2+lpcnet and
>     ran into this, but only on non-x86 arches:
> 
>     [ 25%] Building CXX object src/CMakeFiles/freedv.dir/fdmdv2_main.cpp.o
>     cd /builddir/build/BUILD/freedv-gui-1.4/build_linux/src && /usr/bin/c++  
> -DGIT_HASH=\"None\" -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D__WXGTK__ 
> -I/builddir/build/BUILD/freedv-gui-1.4/src 
> -I/builddir/build/BUILD/freedv-gui-1.4/build_linux/src 
> -I/builddir/build/BUILD/freedv-gui-1.4/build_linux -isystem 
> /usr/lib64/wx/include/gtk3-unicode-3.0 -isystem /usr/include/wx-3.0 -isystem 
> /usr/include/codec2 -isystem /usr/include/lpcnet  -O2 -g -pipe -Wall 
> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS 
> -fexceptions -fstack-protector-strong -grecord-gcc-switches 
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mcpu=power8 -mtune=power8 
> -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -pie -Wl,-z,relro 
> -Wl,-z,now -Wall -pthread -O2 -g -DNDEBUG   -o 
> CMakeFiles/freedv.dir/fdmdv2_main.cpp.o -c 
> /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp
>     /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp: In function 
> 'int resample(SRC_STATE*, short int*, short int*, int, int, int, int)':
>     /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp:3663:14: 
> warning: variable 'ret' set but not used [-Wunused-but-set-variable]
>      3663 |     int      ret;
>           |              ^~~
>     /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp: In function 
> 'void txRxProcessing()':
>     /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp:3958:13: 
> warning: variable 'ret' set but not used [-Wunused-but-set-variable]
>      3958 |         int ret;
>           |             ^~~
>     /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp: In function 
> 'void __cpuid(int*, int)':
>     /builddir/build/BUILD/freedv-gui-1.4/src/fdmdv2_main.cpp:4484:5: error: 
> impossible constraint in 'asm'
>      4484 |     __asm__ __volatile__(
>           |     ^~~~~~~
> 
> 
>     Full log:
> 
>     https://kojipkgs.fedoraproject.org//work/tasks/2413/44862413/build.log
> 
> 
>     Thanks,
> 
>     Richard
> 
> 
>     _______________________________________________
>     Freetel-codec2 mailing list
>     [email protected]
>     <mailto:[email protected]>
>     https://lists.sourceforge.net/lists/listinfo/freetel-codec2
> 
> 
> 
> _______________________________________________
> Freetel-codec2 mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/freetel-codec2
> 


_______________________________________________
Freetel-codec2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freetel-codec2

Reply via email to