On Sun, 2005-07-10 at 12:19 +0200, Dirk Meyer wrote: > More or less, kaa.notifier is doing the select for us. So it is more > kaa.notifier.addSocket(win.get_display().socket, > win.get_display().handle_events) > kaa.notifier.loop()
I still would like a kaa.main() function that basically wraps kaa.notifier.loop(). Seems more readable. So I added it. > o move around some variables in header and c files to make it compile > without evas installed. :) Ok, good. My code starts to get sloppier as the clock approaches midnight. :) > o shorten lines to 80 chars I have my vims at 130 columns. Back in the days when everyone was still running in console, I could understand the need for wrapping at 80 columns. But it's 2005, and making your editor wider is pretty easy. :) I find 130 columns is a pretty good width for coding. If lines go longer than that then it's a pretty good indication I'm trying to do too much on one line. (People use that same argument for 80 columns but I don't agree; once you're nested a few levels, indentation removes a lot of columns.) Also hard-breaking lines often really reduces readability. But we should standardize on a style. I vote for 130 columns, obviously, but I'll hear arguments for 80. :) In any case, your indentation changes have mixed spaces and tabs. Either we use tabs for all indentation and spaces for aligning, or we don't use tabs at all ever anywhere. :) Speaking of style, the notifier naming conventions are different. It uses functionNamesLikeThis(), rather than functions_like_this(). I guess this is a complicated matter to fix because pynotifier isn't part of kaa, but kaa.notifier is, and I really notice it looks out of place. Jason.
signature.asc
Description: This is a digitally signed message part
