Jason Tackaberry wrote:
> Author: tack
> Date: Fri Dec 22 20:33:07 2006
> New Revision: 2283
>
> Modified:
> trunk/popcorn/src/backends/xine/child.py
> trunk/popcorn/src/generic.py
>
> Log:
> Generic player shouldn't determine what to do with deinterlace='auto', that
> should be left up to the individual backend, because each backend has
> different behaviour for deinterlacing (e.g. with xine you can have tvtime
> in the filter chain and it will not activate on progressive content).
>
>
> Modified: trunk/popcorn/src/backends/xine/child.py
> ==============================================================================
> --- trunk/popcorn/src/backends/xine/child.py (original)
> +++ trunk/popcorn/src/backends/xine/child.py Fri Dec 22 20:33:07 2006
> @@ -326,7 +326,7 @@
>
> # wire video stream with needed filter
> chain = []
> - if properties.get('deinterlace'):
> + if properties.get('deinterlace') in (True, 'auto'):
> chain.append('tvtime')
> if properties.get('postprocessing'):
> chain.append('pp')
>
> Modified: trunk/popcorn/src/generic.py
> ==============================================================================
> --- trunk/popcorn/src/generic.py (original)
> +++ trunk/popcorn/src/generic.py Fri Dec 22 20:33:07 2006
> @@ -265,11 +265,6 @@
> properties = self._player._properties
> properties = properties.copy()
>
> - if properties.get('deinterlace') == 'auto':
> - properties['deinterlace'] = False
> - if 'interlaced' in self._media and self._media.interlaced:
> - properties['deinterlace'] = True
> -
> self._player = cls(self._config, properties)
> self._player._state_changed.connect_weak(self._state_change)
> for signal in self._player.signals:Now we have the problem that mplayer has no way of knowing that the content is interlaced or not. self._media was the mmpython result with that info. And BTW, are you sure tvtime does the correct thing when used with an avi? IIRC the detection only works for mpg. Dischi -- Computer analyst to programmer: "You start coding. I'll go find out what they want."
pgpfJFsZyPabJ.pgp
Description: PGP signature
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
