Jason Tackaberry wrote: > On 2008-01-08 15:27, Dirk Meyer wrote: >> now that we have moved everything from kaa notifier into the kaa >> namespace, what about strutils? IMHO kaa.unicode_to_str is much better >> than kaa.strutils.unicode_to_str. I would like to add __all__ from >> strutils to the kaa namespace. > > I don't know I'd say it's much better. It's shorter. But whereas > 'notifier' was a bit vague (unless you knew kaa internals), strutils > seems obvious to me. But if you feel like importing strutils.* into the > kaa namespace, I don't object too much. > > >> And about the latest changes: kaa.main.start() does not look right to >> me. Calling start() is something different than loop(), because I do >> not expect start to block, I expect it to start it. So maybe >> main.run() is better or keep the old main(). > Well we could take a page from gtk's good here, and use main.run() and > main.quit() > > I like the kaa.main namespace. I don't want kaa.main(). I prefer > kaa.main.run() if we're going to change it.
So let us make it run() and quit() or shutdown(). >> After some thinking, I also think we should not deprectate the old >> code. You can still use kaa.notifier.Timer and not only kaa.Timer. So >> IMHO kaa.notifier.step(), loop(), shutdown() and init() should remain, >> running should be deprectated and is_running() should be in the >> kaa.notifier namespace. > > In otherwords practically entirely rollback the changes we made over the > last couple days? :) Sort of. > > I really don't like the kaa.notifier namespace. The notifier is an > internal detail that's unnecessary to expose in the API. Timers, > callbacks, signals, threads, etc. are very common and core functions and > I do think these belong in the kaa namespace. Yes, they do, I do not disagree. But is it bad to keep the notifier namespace, too? Right now we can call BOTH kaa.Timer and kaa.notifier.Timer. Why is it allowed to call kaa.main.step and not kaa.notifier.step? > And having both kaa.notifier.Timer and kaa.Timer as "ok" is not > pythonic. It's perly, but not pythonic. :) We should have one way to > do it, and discourage the other ways. And I do think we got it right > the second time with kaa.Timer. So you propose no "notifier" in external code, right? Dischi -- "error located between ears of user!"
pgpa9Zly6GUKL.pgp
Description: PGP signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
