Folks, today I upgraded from 1.7.6.1 to 1.8.0. Everything went very smoothly - nice work!
But I discovered a little bug, that the 1.7 series has as well: Provided SENSORS_PLATFORM_PATH exists, the getSensorPath(...) method in plugins.idlebar.system.sensors simply returns _some_ existing directory from that path. In my case, an # ls -l /sys/devices/platform shows: drwxr-xr-x 3 root root 0 24. Apr 18:13 coretemp.0 drwxr-xr-x 3 root root 0 24. Apr 18:13 coretemp.1 drwxr-xr-x 5 root root 0 24. Apr 18:13 i8042 drwxr-xr-x 3 root root 0 24. Apr 18:13 it87.656 drwxr-xr-x 3 root root 0 24. Apr 18:13 pcspkr drwxr-xr-x 2 root root 0 24. Apr 18:13 power -rw-r--r-- 1 root root 4096 24. Apr 18:13 uevent Since Python returns the list of subdirectories in alphabetical order, the path returned by getSensorPath(...) is /sys/devices/platform/coretemp.0 The coretemp module, on the other hand, doesn't create the necessary <Sensorname>_max file, thus the plugin raises an exception upon freevo start. Therefore, only directories that contain the necessary files for the idlebar.sensors plugin should be taken into account, in my case _only_ /sys/devices/platform/it87.656 represents a temperature sensor. The attached small - hence very simple ;o) - patch fixes this issue. Would be glad to see it in the next release... Torsten -- Never make anything simple and efficient when a way can be found to make it complex and wonderful. - Murphy's Law No. 13 -
freevo-1.8.0-getSensorPath.patch
Description: Binary data
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
