Hans Meine wrote:
> Am Dienstag, 07. Oktober 2008 22:08:26 schrieb Duncan Webb:
>> Dirk Meyer wrote:
>> > I would prefer to have all trailing whitespaces removed anyway. What
>> > do other people think?
>>
>> Why don't you run the code through reindent.py one of the tools in
>> Python-2.5, it removes trailing spaces and replaces tabs with spaces.
>
> IMHO that would be a very good idea.  However, I just tried running stock 
> reindent.py and I think one would have to adapt it a little bit; e.g. eyeD3 
> should be excluded

And pynotifier in kaa.base. We should exclude all external files.

> and I would not let it remove whitespace from empty lines (rationale
> see my elisp code), which is quite valid and produces too large
> changes.

I don't care if it is valid, I do not like trailing
whitespaces. E.g. I add a line to a function and remove it later
before checkin. Sometimes the line is still different because I had
more or less whitespaces than before. We should _always_ delete
trailing whitespaces. I do it from time to time. E.g. when coding
kaa.candy I made some cleanup check-ins. In that I removed the
whitespaces, added some doc and renamed some variables.

> However, removing trailing whitespace and converting some stray tabs
> to spaces looks like a good idea to me.

There should be no tabs in the code (I hope).


Dischi

-- 
A computer without Windows is like a chocolate cake without mustard.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to