Am Mittwoch, 08. Oktober 2008 22:38:00 schrieb Dirk Meyer:
> Hans Meine wrote:
> > IMHO that would be a very good idea. However, I just tried running stock
> > reindent.py and I think one would have to adapt it a little bit; e.g.
> > eyeD3 should be excluded
>
> And pynotifier in kaa.base. We should exclude all external files.
Yes. In metadata/TODO, also "the discID code" is referenced as external code.
So far, I only know about these three.
> > and I would not let it remove whitespace from empty lines (rationale
> > see my elisp code), which is quite valid and produces too large
> > changes.
>
> I don't care if it is valid, I do not like trailing whitespaces.
My point is that this will not be considered trailing whitespace at all by
many people (~ denotes \n):
if condition:~
foo = 42~
bar = "baz"~
~
do_something_to_conclude()~
Note that the "empty" line technically has "trailing whitespace", although you
would typically not call that "trailing" but valid indentation whitespace.
In fact, if you run stock reindent, maybe half of the changes are removing
this indentation from empty lines; I consider that too much "noise". (In
fact, I think I would just remove leading tabs and trailing whitespace from
non-empty lines, for which I would propose to write a 10-liner instead of
modifying reindent.py.)
If you disagree, it becomes even easier; just run reindent on the whole repo
and commit. If I should do so, please tell me; I don't want to create
conflicts on your side without being officially told to.
Have a nice day,
Hans
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
