On Tue, Jan 23, 2007 at 01:05:31PM +0000, Thorsten Glaser wrote:
> Phil Sutter dixit:
>
> >You're sure this is how the dependency mentioned above ought to be used?
> >Doesn't it rather decide whether a package should be installed into the
> >rootfs image?
>
> Yes and no. If it's y/m it should be built. If it's y it should be
> packaged into the root fs, but that's not what I mean here.
| ifeq ($(FWRT_PACKAGE_$(1)),y)
What did that check again? Ah, wait: it's 'y'. What's done when this
check succeeds? So again, what did you say this was for?
> >Rewriting all calls to PKG_template is not acceptable.
>
> Why? We're touching all Makefiles anyway. Plus, this'd be easy to script.
I don't care the work, I just see no sense in it.
> >This is why I
> >suggested a solution where only the template has to be changed
>
> How would you do that? In the asterisk case, what differences
> are between the first and the second call?
Doesn't matter. For me it's enough if a simple 'make' builds everything
that has been selected, a 'make package=foobar' may build every
sub-package of foobar.
> >> An alternative solution:
> >> - ifeq ($(FWRT_PACKAGE_$(1)),y)
> >> + ifneq (${FWRT_PACKAGE_$(1)}${DEVELOPER},)
> >
> >This is about what I want to have, but best defined as make function, so
> >one doesn't have to type so much, and it's easy to remember.
>
> No, that's INSIDE the template.
Yes, where else??
> >Please note that the problem is merely missing control over what
> >sub-packages are build when using 'package=foobar'
>
> Wrong, because a full make has the same problems(*).
Sure, you're just telling me my problem is wrong??
> >This is the jumping point (taken from mk/package.mk):
> >| ifneq ($(FWRT_PACKAGE_$(1)),)
> >| compile-targets: $$(IPKG_$(1))
> >| endif
> >| ifneq ($(DEVELOPER),)
> >| compile-targets: $$(IPKG_$(1))
> >| endif
>
> compile-targets are no longer used.
>
> That's what I meant.
Obviously, they should yet.
Greetings, Phil
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
