Phil Sutter dixit:
>Maybe you committed something else than what you've
>tested.
I had only tested the sed stuff, that was the issue.
That typos were other optimisations that for themselves
were safe but not combined.
>It's quite hard for me to believe you really checked in such
>lousy mistakes in the script.
DO YOU WANT ME TO POINT OUT EVERY SINGLE LOUSY MISTAKE
IN EVERY CHANGESET YOU COMMITTED AND BASH YOU WITH THAT
NOW? We're all human, do errors, have good and bad days,
and are usually hacking way past (ordinary) bedtime. It
is natural for some typos, thinkos and pastos to slip
through.
>Next point is the second call to sed, using params I don't understand
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
So it's bad because _you_ lack basic Unix knowledge?
If your operating system doesn't have a manual page for
sed, read http://www.mirbsd.org/man1/sed.htm then.
>In my eyes your code finds all lines containing __module_parm_, replaces
>everything from beginning of the line to __module_parm_ inclusively with
>' -K ' and that's it.
And outputs these lines (the 'p'). And nothing else (the '-n').
Yes it is the same. (I could even save the 'tr' call by using
a construct like
- T="$T --strip-unneeded$(${prefix}nm $F | sed -n \
- '/__module_parm_/s/^.*__module_parm_/ -K /p' | tr -d '\n')"
+ T="$T --strip-unneeded $(echo $(${prefix}nm $F | sed -n \
+ '/__module_parm_/s/^.*__module_parm_/-K /p'))"
Heck, I'll commit that because bash has a builtin echo, so it
saves us a fork'n'exec, and maybe you don't understand tr(1)
either.
bye,
//mirabile
--
"Using Lynx is like wearing a really good pair of shades: cuts out
the glare and harmful UV (ultra-vanity), and you feel so-o-o COOL."
-- Henry Nelson, March 1999
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
