Hi,
On Fri, 09 Feb 2007 at 13:37 +0000, Thorsten Glaser wrote:
> Phil Sutter dixit:
>
> >Maybe you committed something else than what you've
> >tested.
>
> I had only tested the sed stuff, that was the issue.
> That typos were other optimisations that for themselves
> were safe but not combined.
Please always test these critical stuff on a target. Sorry but Phil
is a little bit under pressure right now, he has 3 weeks left to
finish his second practise work, and still the ISDN part is not
working. I do not think he like to fix such a breakage, if he fixed
his problem some hours ago. That is not very motivating. Phil always
make a lot of tests directly on a target, not only in ADK.
We should all do more runtime tests, including me. Shortly before
1.1 release I will introduce a new detailed policy to keep trunk
clean of untested code. This will be more important every day,
because our userbase and developer base getting bigger every month.
In the first days of the project it was not so important, nobody
used FreeWRT and nobody recognized any problems. But right now I
think this is changing.
> >It's quite hard for me to believe you really checked in such
> >lousy mistakes in the script.
>
> DO YOU WANT ME TO POINT OUT EVERY SINGLE LOUSY MISTAKE
> IN EVERY CHANGESET YOU COMMITTED AND BASH YOU WITH THAT
> NOW? We're all human, do errors, have good and bad days,
> and are usually hacking way past (ordinary) bedtime. It
> is natural for some typos, thinkos and pastos to slip
> through.
Sure. But in another mail you are complaining exactly about this
workflow. Please be calm.
> >Next point is the second call to sed, using params I don't understand
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> So it's bad because _you_ lack basic Unix knowledge?
Don't be such an asshole and do not get personal. Your shell style
is very cryptic, not everybody is a shell and make genius like you
are. Be polite and try to explain things. And a good description for
critical code can never be bad.
> Heck, I'll commit that because bash has a builtin echo, so it
> saves us a fork'n'exec, and maybe you don't understand tr(1)
> either.
Get over it.
Stop this shit now. We all now concentrate on doing the best for our
project.
Thank you very much
Waldemar
--
don't open your wrt, free it
http://www.freewrt.org
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
