Thorsten Glaser <[EMAIL PROTECTED]> writes:

> Simon Josefsson dixit:
>
>>Hi!  This update gnutls to v2.0.0 and generally clean up the freewrt
>>build situation for gnutls.
>
> Applied, with minor kludges:

Thanks.  I confirmed that it builds fine here.

>>@@ -9,8 +9,8 @@
>>      default n
>>      select FWRT_COMPILE_GNUTLS
>>      select FWRT_PACKAGE_LIBGCRYPT
>>-     select FWRT_PACKAGE_LIBOPENCDK
>>      select FWRT_PACKAGE_LIBTASN1
>>+     select FWRT_PACKAGE_ZLIB
>>      help
>>        GnuTLS is a project that aims to develop a library which provides a
>>        secure layer, over a reliable transport layer. Currently the GnuTLS
>
> This still seems to be a build dependency, so I noted it
> in package/Depends.mk.

Yes, opencdk is a build dependency, but it is only needed for
libgnutls-extra, not for the core libgnutls.

>> config FWRT_PACKAGE_GNUTLS_UTILS
>>-     prompt   "gnutls-utils.................... The GNU TLS utilities"
>>+     prompt "gnutls-utils...................... The GNU TLS utilities"
>>      tristate
>>      default n
>>      depends FWRT_PACKAGE_LIBGNUTLS
>>+     depends FWRT_PACKAGE_LIBGNUTLS_EXTRA
>
> I made the second “depends” a “select” to improve usability,
> and moved the utilities behind the libraries.

Ok.  I was a bit unsure about the difference between the two.  Is the
behaviour for each documented somewhere?  'depends' felt like a better
term to describe the relationship though, since gnutls-utils does depend
on libgnutls-extra.

>>+     help
>
> I stripped the long explanatory text from the subpackages,
> so that it’s easier to find what package contains what.

Seems better, yes.

>>+DISTFILES:=          ${PKG_NAME}-${PKG_VERSION}.tar.bz2
>> MASTER_SITES:=               ftp://ftp.gnutls.org/pub/gnutls/ \
>
> We prefer .tar.gz files (ok, there are none, so I left the .tar.bz2 as
> is) and HTTP transfer master sites (so I shuffled them a little).

Ok.

/Simon
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers

Reply via email to