Thorsten Glaser <[EMAIL PROTECTED]> writes:
>>Yes, opencdk is a build dependency, but it is only needed for
>>libgnutls-extra, not for the core libgnutls.
>
> We still need to have it compiled, even if the libgnutls-extra
> menu item is not selected, because otherwise the build will
> fail, ¿no?
No, the build wouldn't fail. Gnutls would compile the internal copy of
opencdk (and liblzo) though, but that seems harmless since it would
never be used. What about the following?
Index: Depends.mk
===================================================================
--- Depends.mk (revision 3569)
+++ Depends.mk (working copy)
@@ -49,7 +49,10 @@
gkrellmd-compile: glib-compile
glib2-compile: gettext-compile libiconv-compile libpthread-compile
gmediaserver-compile: id3lib-compile libupnp-compile
-gnutls-compile: libgcrypt-compile liblzo-compile libtasn1-compile
opencdk-compile zlib-compile
+gnutls-compile: libgcrypt-compile libtasn1-compile zlib-compile
+ifeq (${FWRT_PACKAGE_LIBGNUTLS_EXTRA},y)
+gnutls-compile: liblzo-compile opencdk-compile
+endif
gpsd-compile: ncurses-compile uclibc++-compile
httping-compile: openssl-compile
icecast-compile: curl-compile libvorbisidec-compile libxml2-compile
libxslt-compile
If we want to optimize things somewhat we could, if libgnutls-extra is
not selected, pass parameters to gnutls so that it doesn't even bother
building its internal copies of opencdk and libzo for the
libgnutls-extra. I wonder whether if it is worth it though, it adds
some complexity that is harder to maintain in the long run.
>>Ok. I was a bit unsure about the difference between the two. Is the
>>behaviour for each documented somewhere?
>
> As far as I have learned during my time at FreeWRT, this is the
> Linux Kernel menuconfig system – I don’t use Linux myself – and
> “a depends on b” hides ‘a’ from the user’s view unless ‘b’ is
> selected, while “a selects b” means that ‘b’ gets automatically
> selected if the user selects ‘a’, which is how I, from my expe-
> rience as BSD porter, implement dependencies.
Oh, I see, I got it backwards. Thanks for explaining.
/Simon
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
