On 6/25/24 16:44, Ralf Hemmecke wrote:
Hi Qian,

On 6/23/24 16:01, Qian Yun wrote:
 > Commit G should be merged with commit B.

I think you did it correctly.

 > But I still think target "viewports" should not depend on
 > target "stamp-book-viewports"

OK, let's try without that dependency. The book-pdf target depends on the pictures, so everything is fine.

 > I'm doing final testings, if everything is OK, I'll
 > commit B/C/G, D, E/F, H/I with Changelogs and attributions to you.
 > You can handle the rest commits as you see fit.

OK under the conditions below.

 > (I've included one small change that move "subspace(vp)" of section
 > 10.1 to psXtc.

You should not include this part as I mentioned in my last mail.

Then "vp" is not defined, causing error messages in the book, you can
verify that.

Also I checked the generated tmp/vp-ug10.input, since the third argument
to \psXtc is empty, the htex2input.awk will not generate faulty "write"
commands.

Thanks for your review.  After some final testings, I'll do the commit
later.

- Qian

--
You received this message because you are subscribed to the Google Groups "FriCAS - 
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to fricas-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/fricas-devel/ef266333-99b6-497a-a8cf-41b93f400aa2%40gmail.com.

Reply via email to