On Sun, Sep 21, 2008 at 11:17:37AM +0100, Othmane Benkirane <[EMAIL PROTECTED]> wrote: > It's my first message! I'm very pleased to enter to this list!
Welcome. :) > I would like to submit an Finclude script, made to simplify > hackage.haskell.org packages to be included in FW. > You can see it here: http://pastie.org/276631 > I've made it with crazy's(up2date) and vmiklos's(this script is > gnome-scriplet.sh based) help. That nice. Here are a few comments: - Please type a 'make haskell.sh.3' in the include dir then you will see that the schema has some syntax errors. If you want to obfuscate your address then do it like nick-at-foo.com or so; but don't break the documentation generator. - Example is missing. Maybe write one package that uses this schema? That would prove that your schema works as well. - Have you tested the scriptlet? I don't see how the $_F_haskell_register_dir variable gets replaced by its final value during build(). - If you have a look at other schemas, build() is just an alias to Fbuild_foo, and doing this here would be nice as well. So what about moving the Fpatchall and Fcd calls to Fbuild_haskell as well? - If you have a little time, it's far easier for us if you send a git patch: http://frugalware.org/docs/getting-involved#_downloading_and_setting_up_the_repositories Keep up the good work!
pgpqpzyZlHwCw.pgp
Description: PGP signature
_______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
