On Sat, Sep 27, 2008 at 07:10:45PM +0000, Othmane Benkirane <[EMAIL PROTECTED]> 
wrote:
> Because I know that ALL programmers are lazy, I've made an unique patch 
> containing the include script, haskell-x11, xmonad (a tiling window 
> manager) and xmonad-contrib (its extensions), enjoy!

I tend to split this huge patch to 4 separate patches, since they are
logically separate.

>  source/include/haskell.install              |   21 +++++
>  source/include/haskell.sh                   |  109 
> +++++++++++++++++++++++++++

This is fine, applied.

>  source/xlib-extra/haskell-x11/FrugalBuild   |   13 +++

This was broken. Please run fblint in the current dir before you submit,
it will point out some errors for you automatically. I manually added
the depends line, extended makedepends to avoid disabling xinerama
support and added missing sbu, maintainer and contributor lines.

>  create mode 100644 source/x11-extra/xmonad/FrugalBuild

Better, though SBU was still missing, and given that once you have
xinerama support enabled in haskell-x11, the libxinerama depend was
unnecessary here. :)

The other issue is that install scriptlets for dependencies are not
executed by default when building packages in chroot, so the x11 module
was still unregistered. I just fixed haskell.sh to do this.

>  create mode 100644 source/x11-extra/xmonad-contrib/FrugalBuild

Removed unnecessary haskell-x11 from makedepends() since xmonad in
depends() already pulls it in, otherwise fine. Oh and SBU was missing as
well.

Thanks!

(Commits 6af2504, 077be71, 804c514 and 9e87e3e.)

Attachment: pgplGiBx4dObT.pgp
Description: PGP signature

_______________________________________________
Frugalware-devel mailing list
[email protected]
http://frugalware.org/mailman/listinfo/frugalware-devel

Reply via email to