On Sun, Jan 22, 2012 at 12:25 AM, Miklos Vajna <[email protected]> wrote: > On Sat, Jan 21, 2012 at 07:26:33PM +0100, Daniel Exner <[email protected]> > wrote: >> I'm dealing with a package which source got misnamed to tar.bz2, >> although being a tar archive (without compression). >> What I found is, both Fextract methods, the one in utils.sh and the one >> in makepkg use the file name for file identification. >> >> Is there some underlying deeper cause for not using the file command for >> this? >> If not, I would invest some time and send a patch. :) > > I think the only reason is that file -i can be broken easily (just screw > up the /etc/misc/magic.mgc file) and then you can't build any packages > anymore, sounds a bit dangerous. > > A possible workaround is to use options=('noextract') then extract > yourself with the right tool. (And contact upstream, hopefully they'll > correct it in the next version.) > > But maybe it's only me being paranoid. :) > > _______________________________________________ > Frugalware-devel mailing list > [email protected] > http://frugalware.org/mailman/listinfo/frugalware-devel >
Vmiklos I think it's only you being paranoid :) . No ofense but it highly unlikely this will occur. I do however suggest keeping the current mechanism as a fallback. If the archive type can't be properly determined using file -i fall back to file extensions or the other way around , using file -i as a fallback. That way it should be as safe as we can make it. _______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
