FVWM Bug Tracking notification
new message incoming/925
Message summary for PR#925
From: [EMAIL PROTECTED]
Subject: Key binding problem
Date: Sat, 21 Sep 2002 10:04:06 -0500
0 replies 0 followups
====> ORIGINAL MESSAGE FOLLOWS <====
>From [EMAIL PROTECTED] Sat Sep 21 10:04:09 2002
Received: from util2.math.uh.edu ([129.7.128.23])
by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
id 17slnl-0008TW-00
for [EMAIL PROTECTED]; Sat, 21 Sep 2002 10:04:09 -0500
Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail)
by util2.math.uh.edu with esmtp (Exim 4.10)
id 17slnl-0007Vy-00
for [EMAIL PROTECTED]; Sat, 21 Sep 2002 10:04:09 -0500
Received: from localhost ([127.0.0.1] ident=65534)
by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
id 17slni-0008TS-00
for [EMAIL PROTECTED]; Sat, 21 Sep 2002 10:04:06 -0500
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Key binding problem
Message-Id: <[EMAIL PROTECTED]>
Date: Sat, 21 Sep 2002 10:04:06 -0500
Full_Name: Jens Thoms Törring
Version: 2.4.0
CVS_Date:
OS: Linux
X_Server: XF86
Submission from: (NULL) (62.104.208.78)
Hi,
What I found isn't actually a bug but more king of an annoyance:
I can't bind keys like XF86AudioRaiseVolume or XF86AudioLowerVolume.
The reason is simple: in bindings.c in function ParseBinding() the
maximum length of a key name is restricted to 19 characters (plus one
for the trailing '\0'. But both the key names are already 20 chars
long.
A patch is simple: increase the size of the char array key in
ParseBinding() to e.g. 0 and allow lengths of up to 29 characters,
i.e. change the line
n1 = sscanf(token,"%19s",key)
to
n1 = sscanf(token,"%29s",key)
As far as I can see this breaks nothing and testing results in
correct key bindings also for unusually long key names.
Regards, Jens
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
