On Sat, Sep 21, 2002 at 05:38:02PM +0000, Mikhael Goikhman wrote: > On 21 Sep 2002 10:04:09 -0500, [EMAIL PROTECTED] wrote: > > > > Message summary for PR#925 > > From: [EMAIL PROTECTED] > > Subject: Key binding problem > > > > Full_Name: Jens Thoms Törring > > Version: 2.4.0 > > > > > > What I found isn't actually a bug but more king of an annoyance: > > I can't bind keys like XF86AudioRaiseVolume or XF86AudioLowerVolume. > > The reason is simple: in bindings.c in function ParseBinding() the > > maximum length of a key name is restricted to 19 characters (plus one > > for the trailing '\0'. But both the key names are already 20 chars > > long. > > > > A patch is simple: increase the size of the char array key in > > ParseBinding() to e.g. 0 and allow lengths of up to 29 characters, > > i.e. change the line > > n1 = sscanf(token,"%19s",key) > > to > > n1 = sscanf(token,"%29s",key) > > > > As far as I can see this breaks nothing and testing results in > > correct key bindings also for unusually long key names. > > This is already fixed in 2.4.6. Try fvwm-2.4.11.
Anyway, to have some more safety in the future I have increased the number of allowed letters in a key name to 200. It may never be necessary, but if it is we can save us another bug report. Bye Dominik ^_^ ^_^ -- Dominik Vogt, mail: [EMAIL PROTECTED], phone: 0721/91374-382 Schlund + Partner AG, Erbprinzenstr. 4-12, D-76133 Karlsruhe -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
