Dominik Vogt wrote:
Cool. I'll apply the patch shortly. Can you provide something
for the NEWS and AUTHORS files too?
(and ChangeLog, and Modules/ChangeLog)
Done. I also updated the entry in FvwmIconMan.1, which I
realized I hadn't updated since putting in your suggestions,
and making negative values work.
(I'm not 100% sure that using "0" for ReliefThickness will
cause TitleButtons to be flat. But I think so. Anyone have
a better idea if TitleButtons are different than the other
classes of buttons?)
Thanks!
- Chris
Index: ChangeLog
===================================================================
RCS file: /home/cvs/fvwm/fvwm/ChangeLog,v
retrieving revision 1.2472
diff -u -u -r1.2472 ChangeLog
--- ChangeLog 19 Mar 2004 16:39:54 -0000 1.2472
+++ ChangeLog 19 Mar 2004 17:19:04 -0000
@@ -49,6 +49,11 @@
(__place_window):
renamed function
+2004-03-15 Chris Ross <[EMAIL PROTECTED]>
+
+ * libs/Graphics.c (do_relieve_rectangle_with_rotation)
+ allow a negative line_width to invert the relief
+
2004-03-06 Marcus Lundblad <[EMAIL PROTECTED]>
* libs/Flocale.c (FlocaleDrawString)
Index: NEWS
===================================================================
RCS file: /home/cvs/fvwm/fvwm/NEWS,v
retrieving revision 1.514
diff -u -u -r1.514 NEWS
--- NEWS 19 Mar 2004 16:39:54 -0000 1.514
+++ NEWS 19 Mar 2004 17:19:04 -0000
@@ -13,7 +13,7 @@
* New BugOpts option ExplainWindowPlacement.
-* Inverted button reliefs in FvwmIconMan.
+* Adjustable button reliefs in FvwmIconMan (option ReliefThickness).
* Security patch in fvwm-bug.
See http://securitytracker.com/alerts/2004/Jan/1008781.html
Index: AUTHORS
===================================================================
RCS file: /home/cvs/fvwm/fvwm/AUTHORS,v
retrieving revision 1.90
diff -u -u -r1.90 AUTHORS
--- AUTHORS 15 Mar 2004 15:53:16 -0000 1.90
+++ AUTHORS 19 Mar 2004 17:19:04 -0000
@@ -235,6 +235,9 @@
Autoconf & automake support, configuration & portability
improvements, and general code gadfly a la Paul Smith.
+Chris Ross:
+Addition of ReliefThickness feature to FvwmIconMan.
+
Paul D. Smith:
Purify support (heap rot, array overwrites, memory stompage of all
sorts). Some autoconf/automake/portability help. Initial cut at a
Index: modules/ChangeLog
===================================================================
RCS file: /home/cvs/fvwm/fvwm/modules/ChangeLog,v
retrieving revision 1.1106
diff -u -u -r1.1106 ChangeLog
--- modules/ChangeLog 19 Mar 2004 09:50:18 -0000 1.1106
+++ modules/ChangeLog 19 Mar 2004 17:19:07 -0000
@@ -1,7 +1,15 @@
-2004-03-19 Dominik Vogt <[EMAIL PROTECTED]>
+2004-03-15 Chris Ross <[EMAIL PROTECTED]>
- * FvwmIconMan/FvwmIconMan.c:
- applied inverted relief patch by Chris Ross
+ * FvwmIconMan/FvwmIconMan.1:
+ * FvwmIconMan/FvwmIconMan.h:
+ * FvwmIconMan/globals.c (init_win_manager):
+ * FvwmIconMan/readconfig.c (read_in_resources):
+ * FvwmIconMan/xmanager.c (draw_3d_icon)
+ (draw_relief):
+ Added ReliefThickness option to FvwmIconMan to control
+ the width of the relief used for both icon manager buttons
+ and icons. Works much the same as the Frame specification
+ of FvwmButtons.
2004-03-15 Dominik Vogt <[EMAIL PROTECTED]>
Index: modules/FvwmIconMan/FvwmIconMan.1
===================================================================
RCS file: /home/cvs/fvwm/fvwm/modules/FvwmIconMan/FvwmIconMan.1,v
retrieving revision 1.28
diff -u -u -r1.28 FvwmIconMan.1
--- modules/FvwmIconMan/FvwmIconMan.1 19 Mar 2004 09:50:18 -0000 1.28
+++ modules/FvwmIconMan/FvwmIconMan.1 19 Mar 2004 17:19:07 -0000
@@ -252,11 +252,13 @@
still only be applied with plainbutton. See FvwmTheme.
.IP "*FvwmIconMan: [id] ReliefThickness \fInum\fP"
-\fInum\fP is a positive integer specifying the number of pixels thick
-that the relief at the edge of non-flat buttons should be. This has
-no effect on flat buttons. In theory, you should be able to set this
-to a negative number and have it act like \fIReverse\fP, but negative
-numbers don't work. This may change later.
+\fInum\fP is an integer specifying the number of pixels thick
+that the relief at the edge of non-flat buttons should be. Setting
+this to 0 will produce flat buttons, as if the values for
+\fIFocusAndSelectButton\fP, \fIFocusButton\fP, \fIIconButton\fP,
+\fIPlainButton\fP, \fISelectButton\fP, and \fITitleButton\fP were
+all set to \fIflat\fP. If \fInum\fP is negative, the button
+will be inverted as if you had used \fIReverse\fP for all classes.
.IP "*FvwmIconMan: [id] Resolution \fIresolution\fP"
Specifies when the manager will display an entry for a certain
