On Thu, Aug 19, 2004 at 11:57:21PM -0400, Jim C. Brown wrote: > On Wed, Aug 04, 2004 at 12:25:39PM +0200, Dominik Vogt wrote: > > > I don't feel confortable playing around with the Makefiles so I just added > > > #define USE_MAILDIR at the top of Goodies.c (I'm hoping that someone who > > > knows more can do this right). > > > > Using compile time configuration in general and #ifdef in > > particular is not the right way in fvwm. Every feature has to be > > configurable at run time. Here is what I would do: > > > > - Add a new config variable, e.g. MailDir > > - Add a flag that indicates whether MailBox or MailDir is used. > > - Split the __cool_get_inboxstatus() function into two sub > > functions __cool_get_inboxstatus_mailbox() and > > cool_get_inboxstatus_maildir() and call one of them from > > cool_get_inboxstatus() according to the flag state. > > > > Done. Set "*FvwmTaskBar: MailDir" in the config file to toggle the flag.
I'd like to commit the patch, but I have a few questions/requests first. * Is it *guaranteed* that "/new" and "/cur" are the proper subdirectory names? Or is there any chance the user can configure these names? * You can safely remove the comments /* forgot this bit of garbage-cleaning in the original patch */ * Comments with "//" can not be used as this is not allowed in the C89 standard. * Can you please add an entry to the man page, the AUTHORS and the modules/ChangeLog file? * I'm afraid of using the scandir() and alphasort() functions. According to the man page, these are non-standard funtions that come from BSD 4.3. I guess they are not available on many systems. Can the code be written without them? > I considered adding Postfix-style detection (checking for the '/' at the end > of the filename). I can't decide which of the two is the better idea, so I > decided to attach both versions. I'd use a separate config option. I think it is less confusing. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED]
pgpuTSuO1vjH3.pgp
Description: PGP signature
