On Fri, Aug 27, 2004 at 05:25:18PM -0400, Jim C. Brown wrote: > On Thu, Aug 26, 2004 at 10:48:06AM +0200, Dominik Vogt wrote: > > I'd like to commit the patch, but I have a few questions/requests > > first. > > > > * Is it *guaranteed* that "/new" and "/cur" are the proper > > subdirectory names? Or is there any chance the user can > > configure these names? > > If the user changes these names, all known Maildir software will break > (including > qmail itself). So this is very unlikely. The Maildir format specifies 3 > subdirectories, cur for current mail, new for new mail, and tmp for mail > that is still being written too/modified (this is to prevent partially > delivered mail).
Okay. [snip] > > * Can you please add an entry to the man page, the AUTHORS and > > the modules/ChangeLog file? > > How? Do you want me to just edit my versions (from fvwm 2.5.8) and send a > patch for each? Yes, patches are fine. Even if there are problems applying the patches, it's easy to do by hand for these files. Don't bother with AUTHORS and ChangeLog, I'va already written the entries. > > * I'm afraid of using the scandir() and alphasort() functions. > > According to the man page, these are non-standard funtions that > > come from BSD 4.3. I guess they are not available on many > > systems. Can the code be written without them? > > Yes, by using opendir(3) and readir(3). This new function, f_scandir, doesn't > sort the directory entries but I don't see why that would be a problem. > > I'm not sure how to handle malloc() errors, so I went with returning what > it already had. Maybe it would be better to free the memory and return an > error? Use the safemalloc() and saferealloc() functions from the library. They take care of error handling (i.e. they abort() the program if allocation fails). I'll apply your patch and do these changes myself. > > > I considered adding Postfix-style detection (checking for the '/' at the > > > end > > > of the filename). I can't decide which of the two is the better idea, so I > > > decided to attach both versions. > > > > I'd use a separate config option. I think it is less confusing. > > Done. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED]
pgpbrHGedlb5H.pgp
Description: PGP signature
