On Sat, Nov 27, 2021 at 4:11 PM Dominik Vogt <dominik.v...@gmx.de> wrote: > > On Sat, Nov 27, 2021 at 02:44:07PM -0700, Jaimos Skriletz wrote: > > > then FvwmButtons will resize to fit without preserving aspect ratio. > > FvwmButtons does honour the aspect ratio (see above). >
If you set a geometry, *FvwmButtons: Geometry 100x100, the aspect ratio hints do not get set (as in the default-config), and you can resize the window to be any size. So it is possible to turn off the aspect ratio hints to work with FvwmButtons. > > At the time we chose to have it be disabled via just setting a > > geometry string vs having an additional option to turn preserving > > aspect ratio on/off. I would rather have an option to allow users to > > toggle this vs just disable it. > > I disagree. From experience, using the aspect ratio always annoys > the user when resizing a window. It's fine for initial size > calcualtions, but after that, leave it to the user. There are > rare exceptions like video players. It also causes uncommon > problems like with sliding, swallowing in FvwmButtons, or using > "maximize grow grow" in a script. > > Imposing limitations on the use of fvwm's modules is > not the fvwm way of doing things. FvwmPager is capable of dealing > with any geometry, like all other modules. > I agree that we shouldn't impose limitations, which is why I think this should be configurable (which it kinda is). That way the user can turn on/off the option that resizing the pager honors the aspect ratio of the screen or not. Though this should be something the user can configure via an option in FvwmPager vs we decide for them based on if they set a Geometry or not. > New patch attached -> no problem with 1x1 pixels even when the > desktop is 50x50. > I do like removing the size_inc hints, as there was a bug with these/base_size hints vs the aspect ratio hints. So removing the base size and size_inc hints would fix that. In conclusion, if the aspect ratio hints also go it won't affect me directly. But in terms of configurability, I still think an option where the user can decide to preserve the aspect ratio when resizing the window or not allows the most freedom for users. jaimos
