Hi again, I've realised that my current Blast2GO install script would be a perfect example of where this tweak to fabric_util.py would help - when I wrote the tool_dependencies.xml I didn't appreciate that the download_by_url action was only allowed as the first action - currently it is ignored if listed later in the script (just as any unknown actions are currently ignored).
http://testtoolshed.g2.bx.psu.edu/view/peterjc/blast2go/6e7694a0ae00 (I'm about to try and fix this tool_dependencies.xml file) Peter On Mon, May 13, 2013 at 10:34 AM, Peter Cock <p.j.a.c...@googlemail.com> wrote: > > > Could I suggest an enhancement to abort on undefined action types, > rough patch below (untested)? This will help give a clear error if a new > command is used but the Galaxy host is too old to implement it (which > is exactly the situation we'd see right now on the main Tool Shed if > the new download_file action is used). > > Regards, > > Peter > > > $ hg diff > diff -r 65a81aead95e > lib/tool_shed/galaxy_install/tool_dependencies/fabric_util.py > --- a/lib/tool_shed/galaxy_install/tool_dependencies/fabric_util.py Sun > May 12 11:52:55 2013 -0400 > +++ b/lib/tool_shed/galaxy_install/tool_dependencies/fabric_util.py Mon > May 13 10:29:17 2013 +0100 > @@ -152,6 +152,12 @@ > url = action_dict[ 'url' ] > filename = url.split( '/' )[ -1 ] > common_util.url_download( current_dir, > filename, url ) > + else: > + # This will happen if the > tool_dependencies.xml is using a very new action: > + tool_dependency.status = > app.model.ToolDependency.installation_status.ERROR > + tool_dependency.error_message = > "Undefined action type %r" % action_type > + return > + > > def log_results( command, fabric_AttributeString, file_path ): > """ ___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: http://lists.bx.psu.edu/ To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
