On Mon, Jun 29, 2009 at 2:10 PM, Iustin Pop<[email protected]> wrote:
> On Mon, Jun 29, 2009 at 02:07:29PM +0100, Guido Trotter wrote:
>>
>> If an ident member of an IdentKeyVal relationship starts with no_ or -,
>> handle it the same way we do for a key. Some unittests are added to
>> check that check_ident_key_val behaves as expected.
>>
>> This patch also changes ForceDictType to, for now, fail on such an
>> entry, and the same to happen when creating an instance or modifying its
>> nics or disks.
>>
>> This behavior will be used later on to allow deletion of os entries in
>> os parameters.
>
> OK, I understand -debootstrap, but is no_deboostrap different?
>
No, they behave exactly the same (at least in the patch which we
deferred for discussion to next week)
>> + raise errors.ParameterError("Can't list members when negating an
>> ident")
>
> "No options accepted"? We don't list anything here :)
>
"No options accepted" is too generic, it seems to refer to the command
itself, rather this particular identkeyval.
We could do it specifying the invalid part:
Invalid Parameter: -no:foo
valid disk index")
>> + if not isinstance(disk_dict, dict):
>> + raise errors.OpPrereqError("Invalid disk values dict")
> "Expected dictionary, got '%s'" % str(disk_dict)
> (it's not a dict, therefore it can't be an invalid dict)
>
Sure, will do in all places.
Thanks,
Guido
