On Tue, Dec 29, 2009 at 8:29 PM, Iustin Pop <[email protected]> wrote: > This patch adds explicit errors (instead of notimplemented) in > FileStorage (and the associated TODOs). > --- > lib/bdev.py | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/lib/bdev.py b/lib/bdev.py > index 849bd9e..5253ddb 100644 > --- a/lib/bdev.py > +++ b/lib/bdev.py > @@ -1820,6 +1820,22 @@ class FileStorage(BlockDev): > if err.errno != errno.ENOENT: > _ThrowError("Can't remove file '%s': %s", self.dev_path, err) > > + def Rename(self, new_id): > + """Renamed the file.
"Renames" rather? Otherwise LGTM, it's a simple enough fix you can submit. -- olive
