On Fri, Feb 26, 2010 at 04:43:47PM +0100, Michael Hanselmann wrote:
> By opening the lock file early, other programs can lock the
> state file to prevent ganeti-watcher from restarting daemons.
> Using the pause feature is inherently prone to race conditions.
>
> Before a traceback was logged when the lock file couldn't
> be acquired. Now it'll be a more friendly message.
LGTM, except:
> @@ -551,7 +575,7 @@ def main():
> except errors.JobQueueDrainError:
> logging.error("Job queue is drained, can't maintain cluster state")
> except Exception, err:
> - logging.error(str(err), exc_info=True)
> + logging.exception(str(err))
> sys.exit(constants.EXIT_FAILURE)
Why are you changing to logging.exception? This will still show a
traceback. You only need to remove exc_info=True.
iustin
