2010/2/26 Iustin Pop <[email protected]>:
> LGTM, except:
>> @@ -551,7 +575,7 @@ def main():
>>    except errors.JobQueueDrainError:
>>      logging.error("Job queue is drained, can't maintain cluster state")
>>    except Exception, err:
>> -    logging.error(str(err), exc_info=True)
>> +    logging.exception(str(err))
>>      sys.exit(constants.EXIT_FAILURE)
>
> Why are you changing to logging.exception? This will still show a
> traceback. You only need to remove exc_info=True.

Forgot to mention this in the commit message. logging.exception is
equivalent to logging.error(…, exc_info=True). A backtrace should be
shown here.

Regards,
Michael

Reply via email to