On Mon, Dec 13, 2010 at 3:21 PM, Apollon Oikonomopoulos <[email protected]> wrote: > Add two new functions, _OpenTap and _ProbeTapVnetHdr, to hypervisors.hv_kvm. >
Should they be in hv_kvm or in netutils.py? > _ProbeTapVnetHdr checks if the host side supports IFF_VNET_HDR and thus a > qemu-kvm instance with version >= 0.12.0 and virtio-net can leverage the > kernel's capabilities to perform GSO (see code comments). > Can you explain better in the comment what this exactly is and does? > _OpenTap opens a new tap device suitable for use with qemu-kvm's "-net > tap,fd=n" option. It also enables vnet_hdr support if requested and safe to do > so. > > Note that constants from <linux/if_tun.h> need to be embedded in the code, but > that's what qemu-kvm already does anyway. > Rest looks good! :) Thanks, Guido
