On Wed, Jan 12, 2011 at 1:39 PM, Apollon Oikonomopoulos <[email protected]> wrote: > On 14:55 Tue 21 Dec , Apollon Oikonomopoulos wrote: >> Hi, >> >> On 13:31 Thu 16 Dec , Guido Trotter wrote: >> > On Mon, Dec 13, 2010 at 3:21 PM, Apollon Oikonomopoulos >> > <[email protected]> wrote: >> > > Add two new functions, _OpenTap and _ProbeTapVnetHdr, to >> > > hypervisors.hv_kvm. >> > > >> > >> > Should they be in hv_kvm or in netutils.py? >> I was thinking about that too, but chose to use hv_kvm since KVM is the >> only user of this feature right now. >> >> > > _ProbeTapVnetHdr checks if the host side supports IFF_VNET_HDR and thus a >> > > qemu-kvm instance with version >= 0.12.0 and virtio-net can leverage the >> > > kernel's capabilities to perform GSO (see code comments). >> > > >> > >> > Can you explain better in the comment what this exactly is and does? > Hi, > > Patch with updated commit message follows. What about the location? Should I > move the functions to netutils? >
LGTM Let's leave them here for now, we can always easily move them if we need, later. Thanks, Guido
