On 14:23 Wed 12 Jan , Guido Trotter wrote: > On Wed, Jan 12, 2011 at 1:47 PM, Apollon Oikonomopoulos > <[email protected]> wrote: > > In order to retain backwards compatibility, we ship the shell script > > previously > > generated by _WriteNetScript as a stand-alone script under PKGLIBDIR. The > > script will be used for KVM instance network configuration in the absence > > of a > > user-provided _KVM_NETWORK_SCRIPT. > > > > Should the code for overriding this script (the one that calls > _KVM_NETWORK_SCRIPT) be in ganeti or in this script?
I think it should be in ganeti, as it would be more forwards-compatible if we decide to use things like hooks, multiple-stage configuration etc, but I'm not that heavily biased. What do you think? > should we use ip link set $INTERFACE up, nowadays? Since you use iproute2 anyway, yes. I used ifconfig because that's what was in the original script written out by WriteNetScript, so feel free to change it (or I'll do it if you want) :). Apollon
