On Thu, Jan 13, 2011 at 11:29 AM, Apollon Oikonomopoulos <[email protected]> wrote: > On 10:52 Thu 13 Jan , Guido Trotter wrote: >> As for the rest, yes, let's move to iproute2, I can do it, no prob. >> One last thing: the script should check that IP, INTERFACE and >> NIC_MODE are set and abort otherwise (so ganeti can report the error), >> then LGTM. >> >> Thanks, >> >> Guido > > Revised patch follows. I will retain _KVM_NETWORK_SCRIPT in hv_kvm since > it's marked as an ancillary file, however I'm duplicating the path in > kvm-ifup (using SYSCONFDIR though). Is this acceptable? > > -- > In order to retain backwards compatibility, we ship the shell script > previously > generated by _WriteNetScript as a stand-alone script under PKGLIBDIR. > > Signed-off-by: Apollon Oikonomopoulos <[email protected]> > ---
LGTM (will pull this after the first 2.4 beta, on devel-2.4, does it sound good?) then eventual script improvements and more flexibility will be in design/implementation for 2.5. Thanks, Guido
