On Wed, Oct 26, 2011 at 02:04:55PM +0200, Michael Hanselmann wrote: > Am 26. Oktober 2011 13:55 schrieb Iustin Pop <[email protected]>: > > On Wed, Oct 26, 2011 at 12:46:52PM +0200, Michael Hanselmann wrote: > >> This resolver can use the internal, unlocked functions. > > > > I… somewhat dislike this change/fear it can lead to breakage. Currently, > > we pass a static list, whereas in the future we pass functions. > > > > Basically right now, the list of "frozen" before the upload starts. With > > this change, the node:ip mapping can change even after we start the > > call, and because we share objects without locks on the nodes > > themselves, we don't know if the objects (the nodes) themselves will > > stay consistent. > > Indeed :-( > > > I'm not sure what problem you're trying to fix with this change. > > The problem you mentioned in your review: “Hmm, we instantiate the > ConfigRunner every time now”.
Ah, I see. OK, looking forward to see what you find. iustin
