On Wed, Sep 26, 2012 at 9:42 AM, Iustin Pop <[email protected]> wrote: > On Tue, Sep 25, 2012 at 06:43:48PM +0200, Agata Murawska wrote: >> This adds tests similar to those used for node query. For now the >> prop_queryGroup_noUnknown is disabled and commented out, as it is >> fasifiable with ndparams and ipolicy. It may be removed or fixed >> later on. > > > Hmm. Please commit, I'll take a look at it, this shouldn't happen. As > discussed offline, I think you're misusing rsUnknown instead of > rsNoData. Huh, I forgot to remove this from the commit message, but actually this does not happen anymore. I will test further though :)
> >> Also, prop_queryGrooup_types has one less property checked - it is >> not the case that number of result rows should be equal to number >> of nodes. > > Typo in this description, and: shouldn't you test that number of result > rows is equal to number of *groups*, and not nodes? Yes, but from what I understand we (at least right now) use just one nodegroup, so this will not really test anything. That's why I just removed this test in group case > > LGTM, thanks. > iustin
